Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bound MDX version on all packages #710

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Bound MDX version on all packages #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dune-project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
(depends
(alcotest (and (>= 1.7.0) :with-test))
(eio (= :version))
(mdx (and (>= 2.2.0) :with-test))
(mdx (and (>= 2.2.0) (< 2.4.0) :with-test))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why <2.4.0 specifically? Is there a breaking change in 2.4.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.4.0 started executing code while copying it. Looks like 2.4.1 has reverted this change (https://github.com/realworldocaml/mdx/releases/tag/2.4.1).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it. I guess in the future >2.4.0 <3.0.0 would also work, if they agree to stick to a semantic versioning logic.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it to 2.4.1 in #712.

(logs (and (>= 0.7.0) :with-test))
(fmt (>= 0.8.9))
(cmdliner (and (>= 1.1.0) :with-test))
Expand All @@ -47,7 +47,7 @@
(depends
(eio (= :version))
(iomux (>= 0.2))
(mdx (and (>= 2.2.0) :with-test))
(mdx (and (>= 2.2.0) (< 2.4.0) :with-test))
(fmt (>= 0.8.9))))
(package
(name eio_windows)
Expand All @@ -64,7 +64,7 @@
(synopsis "Effect-based direct-style IO mainloop for OCaml")
(description "Selects an appropriate Eio backend for the current platform.")
(depends
(mdx (and (>= 2.2.0) :with-test))
(mdx (and (>= 2.2.0) (< 2.4.0) :with-test))
(kcas (and (>= 0.3.0) :with-test))
(yojson (and (>= 2.0.2) :with-test))
(eio_linux (and
Expand Down
2 changes: 1 addition & 1 deletion eio_linux.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ depends: [
"dune" {>= "3.9"}
"alcotest" {>= "1.7.0" & with-test}
"eio" {= version}
"mdx" {>= "2.2.0" & with-test}
"mdx" {>= "2.2.0" & < "2.4.0" & with-test}
"logs" {>= "0.7.0" & with-test}
"fmt" {>= "0.8.9"}
"cmdliner" {>= "1.1.0" & with-test}
Expand Down
2 changes: 1 addition & 1 deletion eio_main.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ doc: "https://ocaml-multicore.github.io/eio/"
bug-reports: "https://github.com/ocaml-multicore/eio/issues"
depends: [
"dune" {>= "3.9"}
"mdx" {>= "2.2.0" & with-test}
"mdx" {>= "2.2.0" & < "2.4.0" & with-test}
"kcas" {>= "0.3.0" & with-test}
"yojson" {>= "2.0.2" & with-test}
"eio_linux"
Expand Down
2 changes: 1 addition & 1 deletion eio_posix.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ depends: [
"dune" {>= "3.9"}
"eio" {= version}
"iomux" {>= "0.2"}
"mdx" {>= "2.2.0" & with-test}
"mdx" {>= "2.2.0" & < "2.4.0" & with-test}
"fmt" {>= "0.8.9"}
"odoc" {with-doc}
]
Expand Down
Loading