Bound MDX version on all packages #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
changed the title
SGrondin
approved these changes
Mar 10, 2024
yawaramin
reviewed
Mar 13, 2024
| @@ -34,7 +34,7 @@ | |||
| (depends | |||
| (alcotest (and (>= 1.7.0) :with-test)) | |||
| (eio (= :version)) | |||
| (mdx (and (>= 2.2.0) :with-test)) | |||
| (mdx (and (>= 2.2.0) (< 2.4.0) :with-test)) | |||
There was a problem hiding this comment.
Any reason why <2.4.0 specifically? Is there a breaking change in 2.4.0?
There was a problem hiding this comment.
2.4.0 started executing code while copying it. Looks like 2.4.1 has reverted this change (https://github.com/realworldocaml/mdx/releases/tag/2.4.1).
There was a problem hiding this comment.
Ah, got it. I guess in the future >2.4.0 <3.0.0 would also work, if they agree to stick to a semantic versioning logic.
There was a problem hiding this comment.
I've updated it to 2.4.1 in #712.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#706 only added the bound in one place, but when releasing it's needed on all packages.