Configure topic creation with --topic.createEnabled

README.md

@@ -207,6 +207,12 @@ By default, you could delete a topic. If you don't want this feature, you could
 --topic.deleteEnabled=false
 ```
 
+By default, you could create a topic. If you don't want this feature, you could disable it with:
+
+```
+--topic.createEnabled=false
+```
+
 ## Actuator
 Health and info endpoints are available at the following path: `/actuator`
 

src/main/java/kafdrop/controller/ClusterController.java

@@ -23,6 +23,7 @@
 import kafdrop.model.*;
 import kafdrop.service.*;
 import org.springframework.beans.factory.*;
+import org.springframework.beans.factory.annotation.Value;
 import org.springframework.boot.info.*;
 import org.springframework.http.*;
 import org.springframework.stereotype.*;
@@ -41,13 +42,17 @@ public final class ClusterController {
 
   private final BuildProperties buildProperties;
 
-  public ClusterController(KafkaConfiguration kafkaConfiguration, KafkaMonitor kafkaMonitor, ObjectProvider<BuildInfo> buildInfoProvider) {
+  private final boolean topicCreateEnabled;
+
+  public ClusterController(KafkaConfiguration kafkaConfiguration, KafkaMonitor kafkaMonitor, ObjectProvider<BuildInfo> buildInfoProvider,
+          @Value("${topic.createEnabled:true}") Boolean topicCreateEnabled) {
     this.kafkaConfiguration = kafkaConfiguration;
     this.kafkaMonitor = kafkaMonitor;
     this.buildProperties = buildInfoProvider.stream()
         .map(BuildInfo::getBuildProperties)
         .findAny()
         .orElseGet(ClusterController::blankBuildProperties);
+    this.topicCreateEnabled = topicCreateEnabled;
   }
 
   private static BuildProperties blankBuildProperties() {
@@ -75,6 +80,7 @@ public String clusterInfo(Model model,
     model.addAttribute("missingBrokerIds", missingBrokerIds);
     model.addAttribute("topics", topics);
     model.addAttribute("clusterSummary", clusterSummary);
+    model.addAttribute("topicCreateEnabled", topicCreateEnabled);
 
     if (filter != null) {
       model.addAttribute("filter", filter);

src/main/java/kafdrop/controller/TopicController.java

@@ -40,11 +40,13 @@ public final class TopicController {
   private static final Logger LOG = LoggerFactory.getLogger(TopicController.class);
   private final KafkaMonitor kafkaMonitor;
   private final boolean topicDeleteEnabled;
+  private final boolean topicCreateEnabled;
 
   public TopicController(KafkaMonitor kafkaMonitor,
-                         @Value("${topic.deleteEnabled:true}") Boolean topicDeleteEnabled) {
+                         @Value("${topic.deleteEnabled:true}") Boolean topicDeleteEnabled, @Value("${topic.createEnabled:true}") Boolean topicCreateEnabled) {
     this.kafkaMonitor = kafkaMonitor;
     this.topicDeleteEnabled = topicDeleteEnabled;
+    this.topicCreateEnabled = topicCreateEnabled;
   }
 
   @RequestMapping("/{name:.+}")
@@ -81,6 +83,7 @@ public String deleteTopic(@PathVariable("name") String topicName, Model model) {
    */
   @RequestMapping("/create")
   public String createTopicPage(Model model) {
+    model.addAttribute("topicCreateEnabled", topicCreateEnabled);
     model.addAttribute("brokersCount", kafkaMonitor.getBrokers().size());
     return "topic-create";
   }
@@ -127,13 +130,18 @@ public String createTopicPage(Model model) {
   })
   @RequestMapping(produces = MediaType.APPLICATION_JSON_VALUE, method = RequestMethod.POST)
   public String createTopic(CreateTopicVO createTopicVO, Model model) {
-      try {
+    model.addAttribute("topicCreateEnabled", topicCreateEnabled);
+    model.addAttribute("topicName", createTopicVO.getName());
+    if (!topicCreateEnabled) {
+      model.addAttribute("errorMessage", "Not configured to be created.");
+      return createTopicPage(model);
+    }
+    try {
         kafkaMonitor.createTopic(createTopicVO);
-      } catch (Exception ex) {
-        model.addAttribute("errorMessage", ex.getMessage());
-      }
-      model.addAttribute("brokersCount", kafkaMonitor.getBrokers().size());
-      model.addAttribute("topicName", createTopicVO.getName());
-      return "topic-create";
+    } catch (Exception ex) {
+      model.addAttribute("errorMessage", ex.getMessage());
+    }
+    model.addAttribute("brokersCount", kafkaMonitor.getBrokers().size());
+    return "topic-create";
   }
 }

src/main/resources/templates/cluster-overview.ftl

@@ -149,9 +149,11 @@
             </#list>
             </tbody>
         </table>
-        <a class="btn btn-outline-light" href="<@spring.url '/topic/create'/>">
-            <i class="fa fa-plus"></i> New
-        </a>
+        <#if topicCreateEnabled>
+            <a class="btn btn-outline-light" href="<@spring.url '/topic/create'/>">
+                <i class="fa fa-plus"></i> New
+            </a>
+        </#if>
     </div>
 </div>
 

src/main/resources/templates/topic-create.ftl

@@ -22,40 +22,44 @@
 
 <#setting number_format="0">
 <div>
-    <h2>Topic creation</h2>
+    <h2>Topic creation <#if !topicCreateEnabled> disabled </#if></h2>
     <a class="btn btn-outline-light" href="<@spring.url '/'/>">
         Back
     </a>
-    <div id="create-form">
-        <form action="<@spring.url '/topic'/>" method="POST">
-            <table class="table table-bordered" style="width: 40%; margin-top: 20px">
-                <tbody>
-                <tr>
-                    <td>Topic name</td>
-                    <td align="center"><input type="text" name="name" required></td>
-                </tr>
-                <tr>
-                    <td>Number of partitions</td>
-                    <td align="center"><input type="number" name="partitionsNumber" value="1" required></td>
-                </tr>
-                <tr>
-                    <td>Replication factor</td>
-                    <td align="center"><input type="number" name="replicationFactor" value="${brokersCount}" required></td>
-                </tr>
-                </tbody>
-            </table>
-            <button class="btn btn-success" type="submit">
-                <i class="fa fa-plus"></i> Create
-            </button>
-            <br>
-            <br>
-            <#if errorMessage??>
-                <p>Error creating topic ${topicName}: ${errorMessage}</p>
-            <#elseif topicName??>
-                <p>Successfully created topic <a href="<@spring.url '/topic/${topicName}'/>">${topicName}</a> </p>
-            </#if>
-        </form>
-    </div>
+
+    <#if topicCreateEnabled>
+        <div id="create-form">
+            <form action="<@spring.url '/topic'/>" method="POST">
+                <table class="table table-bordered" style="width: 40%; margin-top: 20px">
+                    <tbody>
+                    <tr>
+                        <td>Topic name</td>
+                        <td align="center"><input type="text" name="name" required></td>
+                    </tr>
+                    <tr>
+                        <td>Number of partitions</td>
+                        <td align="center"><input type="number" name="partitionsNumber" value="1" required></td>
+                    </tr>
+                    <tr>
+                        <td>Replication factor</td>
+                        <td align="center"><input type="number" name="replicationFactor" value="${brokersCount}" required></td>
+                    </tr>
+                    </tbody>
+                </table>
+
+                <button class="btn btn-success" type="submit">
+                    <i class="fa fa-plus"></i> Create
+                </button>
+                <br>
+                <br>
+            </form>
+        </div>
+    </#if>
+    <#if errorMessage??>
+        <p>Error creating topic ${topicName}: ${errorMessage}</p>
+    <#elseif topicName??>
+        <p>Successfully created topic <a href="<@spring.url '/topic/${topicName}'/>">${topicName}</a> </p>
+    </#if>
 </div>
 
 <@template.footer/>