Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure topic creation with --topic.createEnabled #148

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

ohjongsung
Copy link

Don't show the New button when --topic.createEnabled=false
The button is visible by default, no --topic.createEnabled is required

Copy link
Member

@ekoutanov ekoutanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure that the create-enabled/disabled check is performed not only on the UI, but also in the controller code. I.e. the user shouldn't be allowed to bypass the UI and create the topic, if this has been disabled.

@ohjongsung
Copy link
Author

--topic.createEnabled flag is also checked in the controller code.

@ekoutanov ekoutanov merged commit 652f5b2 into obsidiandynamics:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants