Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #278; robust log domain #279

Merged
merged 1 commit into from
Mar 28, 2021
Merged

fix #278; robust log domain #279

merged 1 commit into from
Mar 28, 2021

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Mar 28, 2021 •
edited
Loading

(Combined with #275 (comment), we won’t render the marks with NaN coordinates.)

@mbostock mbostock requested a review from Fil March 28, 2021 01:21
Fil
Fil approved these changes Mar 28, 2021
View reviewed changes
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact in french maths, zéro is both positif and négatif.

English French values
positive strictement positif ]0, +∞[
negative strictement négatif ]-∞, 0[
non-negative positif [0, ∞[
non-positive négatif ]-∞, 0]

@mbostock mbostock merged commit 402aafe into main Mar 28, 2021
@mbostock mbostock deleted the mbostock/robust-log-domain branch March 28, 2021 18:14
@Fil Fil mentioned this pull request Nov 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbostock @Fil