Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log scales are easily broken #278

Closed
Fil opened this issue Mar 27, 2021 · 1 comment
Closed

log scales are easily broken #278

Fil opened this issue Mar 27, 2021 · 1 comment
Labels
question Further information is needed

Comments

@Fil
Copy link
Contributor

Fil commented Mar 27, 2021

When setting the domain automatically, any 0 will break them.
https://observablehq.com/d/4445e77650195594

A secondary issue is that a broken dot (with a NaN screen coordinate) should not be shown, ref. #271 (comment).

@mbostock mbostock added the question Further information is needed label Mar 28, 2021
@mbostock
Copy link
Member

Maybe when inferring the domain for a log scale, if we encounter a positive value, we ignore any negative or zero values, and similarly if we encounter a negative value, we ignore any positive or zero values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is needed
Projects
None yet
Development

No branches or pull requests

2 participants