unpin echarts #987
Merged
unpin echarts #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/unpin-echarts
branch
from
2af3d54
to
5ea2625
Compare
|
Do we need to use echarts.esm.min.js? I tried with this (in recommendedLibraries.js) -export const echarts = () => import("npm:echarts/dist/echarts.esm.min.js");
+export const echarts = () => import("npm:echarts");and it seems to work. (It's also what we document in http://127.0.0.1:3000/lib/echarts). Maybe I'm confused by some caching mystery, though. |
|
They’re the same thing now, with the changes in this PR. I can shorten it. |
Fil
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the latest version works, as long as you use the correct entry (
dist/echarts.esm.min.js).