Skip to content

Commit

Permalink
unpin echarts
Browse files Browse the repository at this point in the history
  • Loading branch information
mbostock committed Mar 6, 2024
1 parent d0fae89 commit 5ea2625
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/lib/echarts.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ index: true
Apache ECharts is available by default as `echarts` in Markdown. You can also import it explicitly like so:

```js run=false
import * as echarts from "npm:echarts/dist/echarts.esm.js";
import * as echarts from "npm:echarts";
```

To use ECharts, declare a container element with the desired dimensions, [display it](../javascript/display), and then call `echarts.init`.
Expand Down
2 changes: 1 addition & 1 deletion src/libraries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export function getImplicitInputImports(inputs: Iterable<string>): Set<string> {
if (set.has("dot")) implicits.add("npm:@observablehq/dot");
if (set.has("duckdb")) implicits.add("npm:@duckdb/duckdb-wasm");
if (set.has("DuckDBClient")) implicits.add("npm:@observablehq/duckdb");
if (set.has("echarts")) implicits.add("npm:echarts/dist/echarts.esm.min.js");
if (set.has("echarts")) implicits.add("npm:echarts");
if (set.has("htl") || set.has("html") || set.has("svg")) implicits.add("npm:htl");
if (set.has("Inputs")) implicits.add("npm:@observablehq/inputs");
if (set.has("L")) implicits.add("npm:leaflet");
Expand Down
6 changes: 3 additions & 3 deletions src/npm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,11 @@ export async function resolveNpmImport(root: string, specifier: string): Promise
? "13.0.0" // https://github.com/observablehq/framework/issues/750
: name === "parquet-wasm"
? "0.5.0" // https://github.com/observablehq/framework/issues/733
: name === "echarts"
? "5.4.3" // https://github.com/observablehq/framework/pull/811
: undefined,
path = name === "mermaid"
? "dist/mermaid.esm.min.mjs/+esm" // TODO
? "dist/mermaid.esm.min.mjs/+esm"
: name === "echarts"
? "dist/echarts.esm.min.js"
: "+esm"
} = parseNpmSpecifier(specifier);
return `/_npm/${name}@${await resolveNpmVersion(root, {name, range})}/${path.replace(/\+esm$/, "+esm.js")}`;
Expand Down

0 comments on commit 5ea2625

Please sign in to comment.