Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsatisfiable classes revealed by ELK 0.5 #1455

Closed
balhoff opened this issue Sep 5, 2018 · 13 comments · Fixed by #2023
Closed

Unsatisfiable classes revealed by ELK 0.5 #1455

balhoff opened this issue Sep 5, 2018 · 13 comments · Fixed by #2023

Comments

@balhoff
Copy link
Member

balhoff commented Sep 5, 2018

Classifying with ELK 0.5, which supports property ranges, reveals a pretty large number of unsatisfiable classes (5590) when the full RO is imported into Uberon (release http://purl.obolibrary.org/obo/uberon/releases/2018-07-30/ext.owl). You've got to import RO to see the problems.

@matentzn
Copy link
Contributor

matentzn commented Sep 7, 2018

This is bad. Do you see any regularities in terms of what is going on? Always part of involved?

@balhoff
Copy link
Member Author

balhoff commented Sep 7, 2018

I think this one is fairly typical:

futurecoelomiccavitylumen

@balhoff
Copy link
Member Author

balhoff commented Sep 7, 2018

Deleting the axiom 'material entity' DisjointWith 'immaterial entity' eliminates all but 4 unsatisfiable classes.

@matentzn
Copy link
Contributor

matentzn commented Sep 7, 2018

Yeah, I thought that might have been the cause. I found a bunch of those where anatomical lines and anatomical structures were mixed and matched together... Solving this will be very important.

@balhoff
Copy link
Member Author

balhoff commented Sep 7, 2018

I guess the pivotal axiom is really 'has developmental contribution from' Range 'anatomical structure'.

@cmungall
Copy link
Member

cmungall commented Sep 7, 2018 via email

@balhoff
Copy link
Member Author

balhoff commented Mar 25, 2019

The range of 'has developmental contribution from' in RO has been loosened to 'anatomical entity'. This seems to have resolved nearly all of these problems. There are 23 remaining unsatisfiable classes (when you import both RO and uberon-caro-bridge into Uberon). The issue is things attached to a border of a bone, where the border is defined as an anatomical line (immaterial entity):

deltoid

@cmungall
Copy link
Member

cmungall commented Mar 28, 2019 via email

@balhoff
Copy link
Member Author

balhoff commented Aug 2, 2021

Only one problem class right now:

subscapularis

@cmungall
Copy link
Member

cmungall commented Aug 2, 2021

I think for now, we change the attachment site to be the scapula, and add a note that it's in the fossa

Removing incoherencies is number one priority, fine grained axiomatization can be added iteratively.

I made a ticket for the broader issues #2017. but this may take a while to resolve

@matentzn
Copy link
Contributor

matentzn commented Aug 4, 2021

I neither see this showing up in uberon.owl nor uberon-edit.obo.. Which file/reasoner are you using?

@balhoff
Copy link
Member Author

balhoff commented Aug 4, 2021

You need to import the full ro.owl and also uberon-bridge-to-caro.

@matentzn
Copy link
Contributor

matentzn commented Aug 4, 2021

#2023 indeed fixes the issue..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants