Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all @atom values in the entire scope must be unique #117

Closed
yegor256 opened this issue Dec 8, 2024 · 3 comments · Fixed by #243
Closed

all @atom values in the entire scope must be unique #117

yegor256 opened this issue Dec 8, 2024 · 3 comments · Fixed by #243
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@yegor256
Copy link
Member

yegor256 commented Dec 8, 2024

Let's check the entire scope of .xmir files under analysis and make sure all values of @atom attribute are unique.

@yegor256 yegor256 added enhancement New feature or request help wanted Extra attention is needed labels Dec 8, 2024
@h1alexbel
Copy link
Contributor

@yegor256 assign me, please

h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 9, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 9, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 14, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 14, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 14, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 14, 2025
@maxonfjvipon
Copy link
Member

@yegor256 why do we need to check that uniqueness? The @atom attribute just contains the "type" of returned object from lambda

@yegor256
Copy link
Member Author

yegor256 commented Jan 16, 2025

@yegor256 @h1alexbel my mistake. Instead, we should check that objects with @atom attribute have unique FQNs. Thus, the following situation is not legit:

In foo.eo:

+package xyz

[] > a /number

In bar.eo:

+package xyz

[] > a /number

The FQN in both objects is xyz.a, but every atom must have a unique one.

h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 16, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 16, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 16, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 20, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 20, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 20, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 20, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 20, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 20, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 20, 2025
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 20, 2025
yegor256 added a commit that referenced this issue Jan 22, 2025
feat(#117): atom-is-not-unique
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants