Skip to content

Commit

Permalink
feat(objectionary#117): allows same atoms with diff fqns
Browse files Browse the repository at this point in the history
  • Loading branch information
h1alexbel committed Jan 20, 2025
1 parent b0dbb8c commit 489b35b
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 1 deletion.
26 changes: 25 additions & 1 deletion src/test/java/org/eolang/lints/errors/LtAtomIsNotUniqueTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ void catchesAtomDuplicatesWithoutPackages() throws Exception {
new MapEntry<>(
"bar",
new ParsedEo(
"org/eolang/lints/errors/atom-is-not-unique/bar.eo"
"org/eolang/lints/errors/atom-is-not-unique/bar-but-foo.eo"
).value()
)
)
Expand All @@ -62,6 +62,30 @@ void catchesAtomDuplicatesWithoutPackages() throws Exception {
);
}

@Test
void allowsSameAtomsWithDifferentFqns() throws Exception {
MatcherAssert.assertThat(
"Defects are empty, but they should not",
new LtAtomIsNotUnique().defects(
new MapOf<String, XML>(
new MapEntry<>(
"foo",
new ParsedEo(
"org/eolang/lints/errors/atom-is-not-unique/foo.eo"
).value()
),
new MapEntry<>(
"bar",
new ParsedEo(
"org/eolang/lints/errors/atom-is-not-unique/bar.eo"
).value()
)
)
),
Matchers.emptyIterable()
);
}

@Test
void catchesAtomDuplicatesWithinSamePackage() throws Exception {
MatcherAssert.assertThat(
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# The MIT License (MIT)
#
# Copyright (c) 2016-2024 Objectionary.com
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included
# in all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.

# Bar.
[] > bar
[] > test /int

0 comments on commit 489b35b

Please sign in to comment.