This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-823] Use SPARK_VERSION_SHORT instead of SPARK_VERSION to find SparkShims
#824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is useful for supporting a spark snapshot version in the future. E.g., for 3.3.0-SNAPSHOT, the short version is 3.3.0. |
PHILO-HE
changed the title
SPARK_VERSION_SHORT instead os SPARK_VERSION to find SparkShimsSPARK_VERSION_SHORT instead of SPARK_VERSION to find SparkShims
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We should use
SPARK_VERSION_SHORTto findSparkShim, not theSPARK_ERSION. As in use environment,SPARK_VERSIONmay be changed, theSPARK_VERSION_SHORTwon't change.How was this patch tested?
Origin GA