Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPPRO-320] Get spark short version for loading corresponding spark shim #578

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

PHILO-HE
Copy link
Contributor

What changes were proposed in this pull request?

In spark, short version stands for major_version-minor_version-patch_version. For a spark release, there is no difference between SPARK_VERSION & SPARK_VERSION_SHORT. But according to some customers' feedback, they are using their internally maintained spark. For example, their SPARK_VERSION can be 3.2.2.xxx. By using SPARK_VERSION_SHORT, gluten can load the expected spark-3.2.2 shim by ignoring the last part.

Ref.: oap-project/gazelle_plugin#824

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[Gluten-${ISSUES_ID}] ${detailed message}

See also:

@jinchengchenghh
Copy link
Contributor

@FelixYBW @zhouyuan as we last discussed, how about that?

@FelixYBW
Copy link
Contributor

@FelixYBW @zhouyuan as we last discussed, how about that?

This PR make sense. What's our discussion?

@jinchengchenghh jinchengchenghh merged commit 469f31b into apache:main Nov 22, 2022
WangGuangxin pushed a commit to WangGuangxin/gluten that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants