Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-540] enable reuse subquery #543

Merged
merged 4 commits into from
Nov 17, 2021
Merged

[NSE-540] enable reuse subquery #543

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4051642
enable reuse subquery
zhouyuan Nov 1, 2021
f3441fe
disable columnar subquery
zhouyuan Nov 16, 2021
c976c9f
DNM: update fastpfor
zhouyuan Nov 16, 2021
38bfa03
Revert "DNM: update fastpfor"
zhouyuan Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...sql-engine/core/src/main/scala/com/intel/oap/expression/ColumnarExpressionConverter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,6 @@ object ColumnarExpressionConverter extends Logging {
columnarDivide,
expr)
}
case oaps: com.intel.oap.expression.ColumnarScalarSubquery =>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this removes columnar subquery support, will fix this in another patch

oaps
case s: org.apache.spark.sql.execution.ScalarSubquery =>
logInfo(s"${expr.getClass} ${expr} is supported, no_cal is $check_if_no_calculation.")
new ColumnarScalarSubquery(s)
case c: Concat =>
check_if_no_calculation = false
logInfo(s"${expr.getClass} ${expr} is supported, no_cal is $check_if_no_calculation.")
Expand Down