This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-540] enable reuse subquery #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
force-pushed
the
wip_reuse_subquery
branch
from
800102a
to
4051642
Compare
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
changed the title
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
commented
Nov 17, 2021
| @@ -271,11 +271,6 @@ object ColumnarExpressionConverter extends Logging { | |||
| columnarDivide, | |||
| expr) | |||
| } | |||
| case oaps: com.intel.oap.expression.ColumnarScalarSubquery => | |||
There was a problem hiding this comment.
note: this removes columnar subquery support, will fix this in another patch
This reverts commit c976c9f.
rui-mo
pushed a commit
to rui-mo/native-sql-engine
that referenced
this pull request
Nov 26, 2021
* enable reuse subquery Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * disable columnar subquery Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * DNM: update fastpfor Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * Revert "DNM: update fastpfor" This reverts commit c976c9f.
|
close #540 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch fixes the subquery reusing. The issue seems introduced by hashagg code change
Note this patch also removed the columnar subquery expression support.
Signed-off-by: Yuan Zhou yuan.zhou@intel.com
How was this patch tested?
locally verified