Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refresh of all ratings for queries #490

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Fix refresh of all ratings for queries #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcb2e35
Fix refresh of all ratings for queries
worleydl Apr 15, 2022
de92e98
Make jslint happy
worleydl Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/assets/javascripts/controllers/searchResults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ angular.module('QuepidApp')
$scope.selectedTry = settingsSvc.applicableSettings();

// Refresh rated-only docs if ratings have changed
$rootScope.$on('rating-changed', function() {
if (!queriesSvc.showOnlyRated) {
$rootScope.$on('rating-changed', function(e, queryId) {
if (!queriesSvc.showOnlyRated && $scope.query.queryId === queryId) {
$scope.query.refreshRatedDocs();
}
});
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/services/ratingsStoreSvc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ angular.module('QuepidApp')
version++;
svcVersion++;

$scope.$emit('rating-changed');
$scope.$emit('rating-changed', queryId);
};

this.setQueryId = function(newQueryId) {
Expand Down