Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joo_global_object is deprecated #103

Closed
dannywillems opened this issue Aug 1, 2023 · 2 comments
Closed

joo_global_object is deprecated #103

dannywillems opened this issue Aug 1, 2023 · 2 comments
Assignees
@dannywillems

Comments

@dannywillems
Copy link
Member

globalThis should be used.

https://github.com/ocsigen/js_of_ocaml/blob/master/CHANGES.md?plain=1#L159
dannywillems added a commit that referenced this issue Aug 1, 2023
@dannywillems
Replace joo_global_object by globalThis
7fd7d6e 
See #103
@dannywillems dannywillems mentioned this issue Aug 1, 2023
Merged
dannywillems added a commit that referenced this issue Aug 15, 2023
@dannywillems
Replace joo_global_object by globalThis
37bf643 
See #103
@L-as
Copy link
Contributor

L-as commented Aug 15, 2023

Link is borked, you need to fix the commit

@dannywillems
Copy link
Member Author

Fixed in !13804

@dannywillems dannywillems self-assigned this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dannywillems dannywillems

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dannywillems @L-as