[develop] Replace joo_global_object by globalThis #13805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
joo_global_object
is used when I was going through the code.joo_global_object
is deprecated, replace byglobalThis
. See https://github.com/ocsigen/js_of_ocaml/blob/master/CHANGES.md?plain=1#L159. I think it is good to replace it as it seems a pretty old deprecation. The warning is not activated in jsoo, but it has been there for more than 2 years and a half. It doesn't seem to be critical. However, globalThis will be used in a following PR adding JS tests in dune, see Share tests between js/wasm and native backends #13537git grep --recurse-submodules "joo_global_object" ":(exclude)src/lib/snarkyjs/src/bindings/compiled"
at the root of the repo.Explain how you tested your changes:
Checklist: