Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Replace joo_global_object by globalThis #13805

Merged

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Aug 1, 2023

Explain your changes:

Explain how you tested your changes:

  • Rely on CI.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@dannywillems dannywillems requested a review from a team as a code owner August 1, 2023 18:00
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems force-pushed the dannywillems/snarkyjs-joo-global-object-deprecated branch from 98b9112 to 74bc136 Compare August 15, 2023 11:01
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems merged commit 954acb7 into develop Aug 17, 2023
@dannywillems dannywillems deleted the dannywillems/snarkyjs-joo-global-object-deprecated branch August 17, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants