Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bug where dev server doesnt close after webpack compile error #167

Merged
merged 2 commits into from
Sep 21, 2016
Merged

fixes bug where dev server doesnt close after webpack compile error #167

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0955390
fixes bug where dev server doesnt close after webpack compile error
ccpricenytimes Sep 20, 2016
690a11b
code review feedback
ccpricenytimes Sep 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cli/actions/dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ const { buildPath, serverSrcPath } = require('../../utils/paths')();
module.exports = (config) => {
logger.start('Starting development build...');

// Kill the server on exit.
process.on('SIGINT', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be

process.on('SIGINT', process.exit);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

process.exit();
});

let clientCompiler;
let serverCompiler;
const { clientConfig, serverConfig } = buildConfigs(config);
Expand Down