fixes bug where dev server doesnt close after webpack compile error #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you ELI5? |
|
So if someone started up dev and received a Webpack compile error they would see an error message. This prompts some users to ^C in their terminal to stop the dev process and make their changes. But this did not kill the underlying process so when restarting the dev server there was a port in use error (more details in @tizmagik comment in #51) What I've done here is created a way to capture that ^C when the user wants to exit and I shut down the process which cleanly exits the running servers. Does that make sense? |
tizmagik
reviewed
Sep 20, 2016
| @@ -18,6 +18,11 @@ const { buildPath, serverSrcPath } = require('../../utils/paths')(); | |||
| module.exports = (config) => { | |||
| logger.start('Starting development build...'); | |||
|
|
|||
| // Kill the server on exit. | |||
| process.on('SIGINT', () => { | |||
There was a problem hiding this comment.
This can be
process.on('SIGINT', process.exit);
delambo
added a commit
that referenced
this pull request
Sep 22, 2016
* master: fixes bug where dev server doesnt close after webpack compile error (#167)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51
The dev server wasn't closing when exiting dev after a Webpack compile error. Now the server exits cleanly.