Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bld): rename MacOS Helper apps #1206

Merged
merged 51 commits into from
Aug 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
9866cab
chore(test): update demo
ayushmanchhabra Aug 18, 2024
fe48306
chore(test): add product_string to demo app
ayushmanchhabra Aug 18, 2024
45a0a5d
chore(bld): move setOsxConfig function out
ayushmanchhabra Aug 18, 2024
73c0a50
chore(test): update MacOS demo
ayushmanchhabra Aug 19, 2024
1ad3870
chore(bld): refactor osx config
ayushmanchhabra Aug 19, 2024
3f0dbbe
chore(bld): add code comments
ayushmanchhabra Aug 19, 2024
0267021
feat(bld): rename MacOS/Contents/nwjs to MacOS/Contents/${app.name}
ayushmanchhabra Aug 19, 2024
b90f5e9
chore(test): add NSHumanReadableCopyright to demo
ayushmanchhabra Aug 19, 2024
6860b63
chore(docs): update license year
ayushmanchhabra Aug 19, 2024
c3624b8
chore(git): use English since Git messus up special chars
ayushmanchhabra Aug 19, 2024
db30da2
chore(test): simplify manual testing
ayushmanchhabra Aug 19, 2024
7ea7057
chore(test): use nw cached in node_modules
ayushmanchhabra Aug 19, 2024
e0f995d
chore(test): add --disable-gpu flag to demo app
ayushmanchhabra Aug 19, 2024
28c7e0e
chore(test): correct file path to demo.js
ayushmanchhabra Aug 19, 2024
166e625
chore(test): correct file path to app fixture
ayushmanchhabra Aug 19, 2024
232fba6
feat(bld): update Helper App executables which reside in Contents/MacOS
ayushmanchhabra Aug 19, 2024
a94022a
feat(bld): update helper apps plist values
ayushmanchhabra Aug 19, 2024
8c77e01
fix(bld): correct path to helper apps
ayushmanchhabra Aug 19, 2024
54e218e
chore(test): use build mode
ayushmanchhabra Aug 19, 2024
b6680ca
chore(test): use osx platform
ayushmanchhabra Aug 19, 2024
e6264ca
chore(test): disable globbing
ayushmanchhabra Aug 19, 2024
c47700c
fix(bld): do not use symlinks since they can fail to be generated
ayushmanchhabra Aug 19, 2024
3d6f1b2
fix(bld): remove duplicate function call
ayushmanchhabra Aug 19, 2024
8fd05be
fix(bld): correct path to helper apps
ayushmanchhabra Aug 19, 2024
7a5c8b6
fix(bld): correct some more helper app paths
ayushmanchhabra Aug 19, 2024
3fd4bf7
fix(bld): correct path to helper apps plist
ayushmanchhabra Aug 19, 2024
8174ad5
fix(bld): correct path to remaning helper apps plist
ayushmanchhabra Aug 19, 2024
ca40c11
chore(bld): update CFBUndleName of Helper apps
ayushmanchhabra Aug 19, 2024
c8f6446
fix(bld): rename Helper apps
ayushmanchhabra Aug 19, 2024
ba86378
chore(deps): uninstall js-green-licenses
ayushmanchhabra Aug 19, 2024
d19cddf
chore(test): setup osx testing
ayushmanchhabra Aug 19, 2024
e44951c
chore(test): prepare osx testing
ayushmanchhabra Aug 19, 2024
76e2fb6
chore(test): update
ayushmanchhabra Aug 19, 2024
82cf7b7
fix(test): correct beforeAll usage
ayushmanchhabra Aug 19, 2024
88b4c1c
chore: remove unused commands
ayushmanchhabra Aug 22, 2024
e4ea474
chore(test): coverage rename of nwjs.app
ayushmanchhabra Aug 22, 2024
758cbcd
fix(git): resolve conflicts
ayushmanchhabra Aug 22, 2024
3a29f47
chore(test): await findpath function
ayushmanchhabra Aug 22, 2024
2a48486
chore(test): coverage for renamed .app files
ayushmanchhabra Aug 23, 2024
a032700
chore(test): run osx tests only on osx
ayushmanchhabra Aug 23, 2024
26c1061
chore(test): fix typo
ayushmanchhabra Aug 23, 2024
7412673
chore(test): coverage for renaming executables correctly
ayushmanchhabra Aug 23, 2024
e6adbad
chore(test): coverage for /Contents/Info.plist
ayushmanchhabra Aug 23, 2024
93533db
chore(test): outDir -> appPath
ayushmanchhabra Aug 23, 2024
5df19dc
chore(test): remove incorrect ContentsInfoPlistJson.name
ayushmanchhabra Aug 23, 2024
96746e9
chore(test): coverage for renaming plist values correctly
ayushmanchhabra Aug 23, 2024
9f04bed
chore(test): fix brackets
ayushmanchhabra Aug 23, 2024
c2e2438
chore(test): remove NSHumanReadableCopyrightc
ayushmanchhabra Aug 23, 2024
84015c2
chore(test): fix CFBundleName
ayushmanchhabra Aug 23, 2024
ee2a38b
chore(ci): run cov on all platforms
ayushmanchhabra Aug 23, 2024
f2e34d6
chore(ci): merge coverage into e2e job
ayushmanchhabra Aug 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,6 @@ jobs:
- windows-2022
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
- name: Checkout repository
uses: actions/checkout@v4.1.7
- name: Setup Volta
uses: volta-cli/action@v4.2.1
- name: Node.js version
run: node -v
- name: npm version
run: npm -v
- name: Install dependencies
run: npm ci
- name: Check for linting errors
run: npm run lint
- name: Run tests
run: npm run test
coverage:
runs-on: ubuntu-22.04
permissions:
contents: read
pull-requests: write
Expand All @@ -50,7 +33,9 @@ jobs:
run: npm -v
- name: Install dependencies
run: npm ci
- name: Enable Coverage
- name: Check for linting errors
run: npm run lint
- name: Run tests
run: npm run test:cov
- name: Report Coverage
if: always()
Expand Down
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2021-2023 NW.js Utilities
Copyright (c) 2021-2024 NW.js Utilities
Copyright (c) 2014-2021 Steffen Müller

Permission is hereby granted, free of charge, to any person obtaining a copy of
Expand Down
Loading