-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bld): rename MacOS Helper apps #1206
Conversation
Coverage Report
File Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at a glance it looks good. I'll test it on my Mac build when I get a chance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified this works as-is. However, a lot of cleanup is possible. I sent a new osx.js file to Ayush which changes line-count from 426 to 177 (removing a ton of repeated code).
🤖 I have created a release *beep* *boop* --- ## [4.10.0](nwutils/nw-builder@v4.9.0...v4.10.0) (2024-08-24) ### Features * **bld:** rename MacOS Helper apps ([nwutils#1206](nwutils#1206)) ([9f3b30f](nwutils@9f3b30f)) ### Chores * **deps:** bump davelosert/vitest-coverage-report-action from 2.5.0 to 2.5.1 in /.github/workflows in the gha group ([nwutils#1210](nwutils#1210)) ([6d69ae3](nwutils@6d69ae3)) * **deps:** bump the npm group across 1 directory with 3 updates ([nwutils#1212](nwutils#1212)) ([20b7e81](nwutils@20b7e81)) * **get:** improve error message when comparing shasums ([nwutils#1213](nwutils#1213)) ([b37068f](nwutils@b37068f)), closes [nwutils#1209](nwutils#1209) * **test:** move tests to seperate dir ([nwutils#1205](nwutils#1205)) ([da0e353](nwutils@da0e353)) * **test:** rename fixtures dir ([c6193bb](nwutils@c6193bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fixes: nwjs/nw.js#7253
Refs: https://nwjs.readthedocs.io/en/latest/For%20Users/Package%20and%20Distribute/