Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bld): rename MacOS Helper apps #1206

Merged
merged 51 commits into from
Aug 23, 2024
Merged

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Aug 18, 2024

  • Updates the Plist properties and renames the relevant executables.

Fixes: nwjs/nw.js#7253
Refs: https://nwjs.readthedocs.io/en/latest/For%20Users/Package%20and%20Distribute/

@ayushmanchhabra ayushmanchhabra changed the title Feat/rename macos helpers feat(bld): rename macos helpers Aug 18, 2024
Copy link
Contributor

github-actions bot commented Aug 18, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 25.74% 546 / 2121
🔵 Statements 25.74% 546 / 2121
🔵 Functions 25% 7 / 28
🔵 Branches 60% 12 / 20
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/bld.js 32.38% 100% 0% 32.38% 114-194, 197-242, 245-287, 290-347, 350-359, 362-384
src/index.js 0% 0% 0% 0% 1-138
src/bld/osx.js 1.86% 100% 0% 1.86% 9-429
Generated in workflow #864

Copy link
Collaborator

@zkrige zkrige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at a glance it looks good. I'll test it on my Mac build when I get a chance

@ayushmanchhabra
Copy link
Collaborator Author

Manual testing results:
1

2 3

@ayushmanchhabra ayushmanchhabra changed the title feat(bld): rename macos helpers feat(bld): rename MacOS Helper apps Aug 19, 2024
Copy link
Contributor

@sysrage sysrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this works as-is. However, a lot of cleanup is possible. I sent a new osx.js file to Ayush which changes line-count from 426 to 177 (removing a ton of repeated code).

@ayushmanchhabra ayushmanchhabra merged commit 9f3b30f into main Aug 23, 2024
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the feat/rename-macos-helpers branch August 23, 2024 18:36
ReiFan49 pushed a commit to ReiFan49/nw-builder that referenced this pull request Nov 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.10.0](nwutils/nw-builder@v4.9.0...v4.10.0)
(2024-08-24)


### Features

* **bld:** rename MacOS Helper apps
([nwutils#1206](nwutils#1206))
([9f3b30f](nwutils@9f3b30f))


### Chores

* **deps:** bump davelosert/vitest-coverage-report-action from 2.5.0 to
2.5.1 in /.github/workflows in the gha group
([nwutils#1210](nwutils#1210))
([6d69ae3](nwutils@6d69ae3))
* **deps:** bump the npm group across 1 directory with 3 updates
([nwutils#1212](nwutils#1212))
([20b7e81](nwutils@20b7e81))
* **get:** improve error message when comparing shasums
([nwutils#1213](nwutils#1213))
([b37068f](nwutils@b37068f)),
closes [nwutils#1209](nwutils#1209)
* **test:** move tests to seperate dir
([nwutils#1205](nwutils#1205))
([da0e353](nwutils@da0e353))
* **test:** rename fixtures dir
([c6193bb](nwutils@c6193bb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS / nw.js 0.42.5] "The display compositor is frequently crashing"
3 participants