Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File & Folder dialogs of the wrong type and undraggable on MacOS #7349

Closed
gpetrov opened this issue Jan 31, 2020 · 6 comments
Closed

File & Folder dialogs of the wrong type and undraggable on MacOS #7349

gpetrov opened this issue Jan 31, 2020 · 6 comments
Assignees

Comments

@gpetrov
Copy link

gpetrov commented Jan 31, 2020

NWJS Version : 0.43.6
Operating System : MacOS 10.14.6

Expected behavior

The file & folder dialogs - should open on the center of the app screen and can not be moved/dragged

Actual behavior

Now it slides from the middle of the app, as a drawer and it is not possible to drag it.
If it should open as drawer then it should be from the top side of the app.
Probably just the popup type is wrong

mac_selectFolder_name_upload

### How to reproduce

Use the following test case:

folder_picker_bug.zip

@gpetrov
Copy link
Author

gpetrov commented Feb 1, 2020

Actually this is even worse when the nwjs app is in full screen, the buttons for cancel and select of the file & folder dialog can go out of the screen! So this makes the file dialog completely unusable on MacOS @rogerwang

See this video after the 26 secs:

https://community.wappler.io/t/file-manager-bug/17075/5?u=george

@gpetrov
Copy link
Author

gpetrov commented Feb 1, 2020

Also tried to use the extensions API chrome.fileSystem, https://developer.chrome.com/apps/fileSystem
To open an folder like:

chrome.fileSystem.chooseEntry({type: 'openFile'}, function(readOnlyEntry) {    
    console.log(readOnlyEntry);
});

but get an error unfortunately:

Unchecked runtime.lastError: Invalid calling page. This function can't be called from a background page.

And it seems the new Chrome native file system api isn't also fully enabled #7351

@cheffe112
Copy link

I can confirm that chrome.fileSystem seems unusable on nw.js since 0.42.4 with

Unchecked runtime.lastError: Invalid calling page. This function can't be called from a background page.

Using 0.42.3, this still works fine.

@gpetrov
Copy link
Author

gpetrov commented Feb 9, 2020

Any news on this issue @rogerwang ? It is getting very urgent as we are getting more and more angry users on Mac that are unable to use the file and folder dialogs ...

Selection buttons fall off screen and the file & folder dialog makes the whole nwjs app jumping around ...

@rogerwang rogerwang self-assigned this Feb 9, 2020
@rogerwang
Copy link
Member

I'll fix them soon.

btw, please don't file multiple cases under one GitHub issue. Thanks.

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants