regression bugfix: import/export configuration broken due to nw.js bug #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From nw.js 0.42.4, the import/export configuration functionality throws an "Invalid calling page. This function can't be called from a background page." error. This has been reported for nw.js already on nwjs/nw.js#7349. Hence, the import/export functionality is currently unusable with nw.js >0.42.3 as integrated in b93078f.
|
Thanks for investigating this! Sounds indeed a bit annoying. Since I don't have a good temporary workaround at the moment, reverting sounds ok for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import/export configuration functionality silently fails since b93078f and simply does nothing when hitting the buttons. Digging deeper, it throws an "Invalid calling page. This function can't be called from a background page." error.
The reason is a bug in nw.js already reported on nwjs/nw.js#7349 and happens from nw.js 0.42.4.
Hence, the import/export functionality is currently unusable with nw.js >0.42.3 as integrated in b93078f.
This bugfix therefore reverts the nw.js version to the last known-to-work one (0.42.3) and also adds a terminal error message to catch this regression in case it appears again.