Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DFPRollingWindowStage to emit correct window #683

Merged
1 commit merged into from
Feb 9, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,10 @@ def _build_window(self, message: DFPMessageMeta) -> MultiDFPMessage:
raise RuntimeError(("Overlapping rolling history detected. "
"Rolling history can only be used with non-overlapping batches"))

train_offset = train_df.index.get_loc(first_row_idx)

# Otherwise return a new message
return MultiDFPMessage(meta=DFPMessageMeta(df=train_df, user_id=user_id),
mess_offset=train_offset,
mess_count=found_count)
mess_offset=0,
mess_count=len(train_df))

def on_data(self, message: DFPMessageMeta):

Expand Down