Update DFPRollingWindowStage to emit correct window #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efajardo-nv
changed the title
|
/merge |
ghost
merged commit
jjacobelli
pushed a commit
to jjacobelli/Morpheus
that referenced
this pull request
Mar 7, 2023
DFPRollingWindowStage was only emitting last batch once `min_history` was met. This PR updates the stage to emit all accumulated rows meeting configured window history requirements. Fixes nv-morpheus#674 Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: nv-morpheus#683
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DFPRollingWindowStage was only emitting last batch once
min_historywas met. This PR updates the stage to emit all accumulated rows meeting configured window history requirements.Fixes #674