Add missing docstrings #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
added
breaking
dagardner-nv
commented
Jan 24, 2023
…ils.logger.parse_log_level which also exist in morpheus.cli.utils
… for that, add an ignore for nested async methods as a work-around for econchick/interrogate#105
mdemoret-nv
approved these changes
Jan 26, 2023
pdmack
reviewed
Jan 26, 2023
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
…v/Morpheus into david-missing-docstrings-549
mdemoret-nv
approved these changes
Jan 26, 2023
|
/merge |
This reverts commit 2359553.
ghost
merged commit
2 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receivermorpheus/clifrom coverage scansvalidation_sizeconstructor argBreaking changes:
Pipeline._do_runis nowPipeline.run_asyncStreamWrapper.startthis method wasn't being used, and wasn't being called._to the nameclick_completion_toolsmoved frommorpheus/utilstomorpheus/climorpheus.utils.type_utils.mirror_argsmethodget_log_levels&parse_log_levelmethods frommorpheus.utils.loggerwhich also exist inmorpheus.cli.utilsfixes [BUG]: Duplicate methods in utils/logger.py #624TODO: