-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC]: Missing docstrings #549
Labels
Milestone
Comments
pdmack
added
non-breaking
Non-breaking change
doc
Improvements or additions to documentation
improvement
Improvement to existing functionality
Needs Triage
Need team to review and classify
labels
Dec 14, 2022
mdemoret-nv
removed
Needs Triage
Need team to review and classify
non-breaking
Non-breaking change
labels
Jan 23, 2023
2 tasks
This is a simple install with: pip install interrogate then running: interrogate -vv -pPsiImM -r "supports_cpp_node$" --omit-covered-files morpheus Right now we have a coverage of 59.8%, looking at the output we can make a good dent in that by documenting (or making private):
|
@bsuryadevara is picking up the following:
|
ghost
pushed a commit
that referenced
this issue
Jan 26, 2023
* Adds docstrings to several public API classes & functions fixes #549 * Remove unreachable custreamz code in `Receiver` * Exclude `morpheus/cli` from coverage scans * Unrelated fix for DFP notebooks missing `validation_size` constructor arg Breaking changes: * `Pipeline._do_run` is now `Pipeline.run_async` * Remove `StreamWrapper.start` this method wasn't being used, and wasn't being called. * Some methods were marked as "private" by prepending a `_` to the name * `click_completion_tools` moved from `morpheus/utils` to `morpheus/cli` * Remove unused `morpheus.utils.type_utils.mirror_args` method * Remove duplicate `get_log_levels` & `parse_log_level` methods from `morpheus.utils.logger` which also exist in `morpheus.cli.utils` fixes #624 TODO: - [x] Build sphinx make sure new docs all look good - [x] Test/verify changes in DFP - [x] Test/verify changes in visualization Authors: - David Gardner (https://github.com/dagardner-nv) - Bhargav Suryadevara (https://github.com/bsuryadevara) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #628
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
How would you describe the priority of this documentation request
Medium
Please provide a link or source to the relevant docs
https://docs.nvidia.com/morpheus/index.html
Describe the problems in the documentation
Casual observation and the use of interrogate reveals several areas where docstrings are missing from classes. Some of these omissions may have been intentional but they all get rendered in the HTML build regardless.
Coverage listed here: https://gist.github.com/pdmack/423e383a21d14352126c3cd993b21fb1
interrogate -vv -pPsiImM -r "name$" -r "supports_cpp_node$" --no-color --omit-covered-files morpheus
(Optional) Propose a correction
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: