Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: Missing docstrings #549

Closed
2 tasks done
pdmack opened this issue Dec 14, 2022 · 2 comments · Fixed by #628
Closed
2 tasks done

[DOC]: Missing docstrings #549

pdmack opened this issue Dec 14, 2022 · 2 comments · Fixed by #628
Assignees
Labels
doc Improvements or additions to documentation improvement Improvement to existing functionality

Comments

@pdmack
Copy link
Contributor

pdmack commented Dec 14, 2022

How would you describe the priority of this documentation request

Medium

Please provide a link or source to the relevant docs

https://docs.nvidia.com/morpheus/index.html

Describe the problems in the documentation

Casual observation and the use of interrogate reveals several areas where docstrings are missing from classes. Some of these omissions may have been intentional but they all get rendered in the HTML build regardless.

Coverage listed here: https://gist.github.com/pdmack/423e383a21d14352126c3cd993b21fb1

interrogate -vv -pPsiImM -r "name$" -r "supports_cpp_node$" --no-color --omit-covered-files morpheus

(Optional) Propose a correction

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open documentation issues and have found no duplicates for this bug report
@pdmack pdmack added non-breaking Non-breaking change doc Improvements or additions to documentation improvement Improvement to existing functionality Needs Triage Need team to review and classify labels Dec 14, 2022
@mdemoret-nv mdemoret-nv removed Needs Triage Need team to review and classify non-breaking Non-breaking change labels Jan 23, 2023
@dagardner-nv
Copy link
Contributor

dagardner-nv commented Jan 23, 2023

This is a simple install with:

pip install interrogate

then running:

interrogate -vv -pPsiImM  -r "supports_cpp_node$" --omit-covered-files morpheus

Right now we have a coverage of 59.8%, looking at the output we can make a good dent in that by documenting (or making private):

  • config.py: ConfigFIL
  • cli/*
  • messages/message_base.py
  • messages/multi_ae_message.py
  • messages/multi_response_message.py
  • pipeline/linear_pipeline.py : LinearPipeline.increment_segment_id should be private
  • pipeline/pipeline.py
  • pipeline/receiver.py
  • pipeline/source_stage.py
  • pipeline/stream_wrapper.py : StreamWrapper.start & StreamWrapper.join
  • stages/general/monitor_stage.py
  • stages/inference/inference_stage.py
  • stages/inference/triton_inference_stage.py
  • stages/input/autoencoder_source_stage.py
  • stages/input/azure_source_stage.py
  • stages/input/cloud_trail_source_stage.py
  • stages/input/duo_source_stage.py
  • stages/input/kafka_source_stage.py
  • stages/postprocess/generate_viz_frames_stage.py
  • stages/postprocess/timeseries_stage.py
  • utils/atomic_integer.py
  • utils/click_completion_tools.py
  • utils/compare_df.py
  • utils/directory_watcher.py
  • utils/logger.py
  • utils/producer_consumer_queue.py
  • utils/type_utils.py

@dagardner-nv
Copy link
Contributor

@bsuryadevara is picking up the following:

 stages/general/monitor_stage.py
 stages/inference/inference_stage.py
 stages/inference/triton_inference_stage.py
 stages/input/autoencoder_source_stage.py
 stages/input/azure_source_stage.py
 stages/input/cloud_trail_source_stage.py
 stages/input/duo_source_stage.py
 stages/input/kafka_source_stage.py
 stages/postprocess/generate_viz_frames_stage.py
 stages/postprocess/timeseries_stage.py

ghost pushed a commit that referenced this issue Jan 26, 2023
* Adds docstrings to several public API classes & functions fixes #549 
* Remove unreachable custreamz code in `Receiver`
* Exclude `morpheus/cli` from coverage scans
* Unrelated fix for DFP notebooks missing `validation_size` constructor arg

Breaking changes:
* `Pipeline._do_run` is now `Pipeline.run_async`
* Remove `StreamWrapper.start` this method wasn't being used, and wasn't being called.
* Some methods were marked as "private" by prepending a `_` to the name
* `click_completion_tools` moved from `morpheus/utils` to `morpheus/cli`
* Remove unused `morpheus.utils.type_utils.mirror_args` method
* Remove duplicate `get_log_levels` & `parse_log_level` methods from `morpheus.utils.logger` which also exist in `morpheus.cli.utils` fixes #624

TODO:
- [x] Build sphinx make sure new docs all look good
- [x] Test/verify changes in DFP
- [x] Test/verify changes in visualization

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Bhargav Suryadevara (https://github.com/bsuryadevara)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #628
@ghost ghost closed this as completed in #628 Jan 26, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation improvement Improvement to existing functionality
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants