Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Cleanup the SID Visualization Example #347

Closed
4 tasks
mdemoret-nv opened this issue Sep 12, 2022 · 0 comments · Fixed by #354
Closed
4 tasks

[FEA] Cleanup the SID Visualization Example #347

mdemoret-nv opened this issue Sep 12, 2022 · 0 comments · Fixed by #354
Assignees
@efajardo-nv
Labels
feature request New feature or request Needs Triage Need team to review and classify
Milestone
Visualization Rep...

Comments

@mdemoret-nv
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The existing SID visualization is in an incomplete state and needs to be cleaned up before merging into Morpheus. The latest implementation is located here: https://github.com/mdemoret-nv/Morpheus/tree/mdd_demo-socket/examples/sid_visualization

Describe the solution you'd like
The following items need to be completed to clean up the example:

  • Update the branch to the latest changes in branch branch-22.09
  • Run the example and fix any issues that come up
  • Improve the setup instructions where necessary
  • Add comments to the code where necessary
@mdemoret-nv mdemoret-nv added feature request New feature or request Needs Triage Need team to review and classify labels Sep 12, 2022
@mdemoret-nv mdemoret-nv added this to the Visualization Repository milestone Sep 12, 2022
@efajardo-nv efajardo-nv mentioned this issue Sep 14, 2022
Merged
@ghost ghost closed this as completed in #354 Sep 16, 2022
ghost pushed a commit that referenced this issue Sep 16, 2022
@efajardo-nv
SID Visualization Example (#354)
ddc0d23 
- Clean up SID visualization example
- Add Morpheus visualization repo as submodule
- Document SID visualization example 

Closes #347
Closes #348 
Closes #349
Closes #205

Authors:
  - Eli Fajardo (https://github.com/efajardo-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)
  - Bartley Richardson (https://github.com/BartleyR)

URL: #354
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efajardo-nv efajardo-nv

Labels
feature request New feature or request Needs Triage Need team to review and classify
Projects
Morpheus Boards
Archived in project
Milestone
Visualization Repository
Development

Successfully merging a pull request may close this issue.

SID Visualization Example efajardo-nv/Morpheus
2 participants
@mdemoret-nv @efajardo-nv