Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pure comment triggering rollup warnings #2725

Closed

Conversation

BobbieGoede
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #2640

Alternative to #2723, uses #__NO_SIDE_EFFECTS__ instead as described in the document referenced in https://github.com/nuxt-modules/i18n/pull/2723/files#r1462054212 as well as https://rollupjs.org/configuration-options/#no-side-effects.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede requested review from kazupon and antfu and removed request for antfu January 23, 2024 00:35
@BobbieGoede
Copy link
Collaborator Author

I still have to test if this would still work with webpack

@kazupon
Copy link
Collaborator

kazupon commented Jan 24, 2024

I still have to test if this would still work with webpack

webpack is not support. πŸ˜…

FYI:
https://github.com/javascript-compiler-hints/compiler-notations-spec/blob/main/no-side-effects-notation-compatibility.md

@BobbieGoede
Copy link
Collaborator Author

I still have to test if this would still work with webpack

webpack is not support. πŸ˜…

FYI: javascript-compiler-hints/compiler-notations-spec@main/no-side-effects-notation-compatibility.md

Ah I understand, that's unfortunate! I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants