fix: rollup comment annotation warning #2723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Resolves #2640
Not sure if it this is the correct way to solve this issue, I don't exactly understand how the comment works and should be handled. I looked at https://github.com/nuxt/nuxt/blob/main/packages/nuxt/src/pages/runtime/composables.ts#L55-L83 for reference, our
defineI18nRoute
macro works in a similar way todefinePageMeta
in Nuxt but that doesn't use a comment like this, whiledefineRouteRules
does which is also similar to our macro.Let me know if this should be solved differently, this change simply removes the comment and adds a usage check just like
definePageMeta
has.📝 Checklist