Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manifest): add option to disable manifest file hash #193

Closed
wants to merge 1 commit into from
Closed

feat(manifest): add option to disable manifest file hash #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/manifest/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,13 @@ function addManifest (_options) {

// Combine sources
const defaults = {
// Module options (not part of the manifest)
publicPath,
fileHash: true,
// Manifest defaults
name: process.env.npm_package_name,
short_name: process.env.npm_package_name,
description: process.env.npm_package_description,
publicPath,
icons: [],
start_url: routerBase + '?standalone=true',
display: 'standalone',
Expand All @@ -36,10 +39,11 @@ function addManifest (_options) {
const manifest = { ...options }
delete manifest.src
delete manifest.publicPath
delete manifest.fileHash

// Stringify manifest & generate hash
const manifestSource = JSON.stringify(manifest)
const manifestFileName = `manifest.${hash(manifestSource)}.json`
const manifestFileName = options.fileHash ? `manifest.${hash(manifestSource)}.json` : 'manifest.json'

// Merge final manifest into options.manifest for other modules
if (!this.options.manifest) {
Expand Down