-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manifest): add option to disable manifest file hash #193
Conversation
By the way, I know this is not the right place to discuss this but last time I tried to submit an issue I used https://cmty.app/nuxt/issues/new?repo=pwa-module but the issue was created there and not imported to Github, do I have to do anything to import the issue to Github? |
Thanks, @mdawar for discovery and PR. So as of WebAPK requirement it seems would be a better idea to make this default behavior to not hash manifest file name. My only concern is that assets inside |
@pi0 Yes I think you're right, the default should be false. And I was going to ask you how to generate the manifest file like the service worker file in the static folder, I used |
Generating to |
Yes no probem, I thought of the Do you want me to set the default |
The problem with I'll include it in changes and certainly, keep your credits for this :) |
Any news here? |
It should be possible to use [name].[ext]?[hash] naming scheme. This way you both keep name and invalidate cache on change. Also it would be handy to edit naming scheme in config for manifest and icons like you do it for webpack loaders. What do you think about it @pi0 ? I'm willing to make PR in few weeks. |
Hi @mdawar @AlexAsh. Sorry for the delay with this. I've added
Still, I believe it is better to remove hash by default but before that Nuxt has to support injecting static assets with custom caching headers. |
Will this feature be released any time soon? The fact that this cannot be resolved on user device without manual intervention once the issue has occurred makes this a pressing issue to still be happening in production |
As per the WebAPKs guide on Google Developers website, it's recommended to not change the manifest file name:
So I have added an option to disable the manifest file hash while keeping the default to
true
.