Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flask test -v sets maxDiff to None #117

Merged
merged 1 commit into from
Apr 13, 2024
Merged

feat: flask test -v sets maxDiff to None #117

merged 1 commit into from
Apr 13, 2024

Conversation

gwhitney
Copy link
Collaborator

@gwhitney gwhitney commented Apr 11, 2024 •
edited
Loading

This causes the output for any test failures to show full diffs, however
large they may be (only when the -v flag is specified).
Resolves #116.

@gwhitney
Copy link
Collaborator Author

one convenient way to test this is to pull the PR, and then "unskip" the sequence test with offset, and run it with and without the -v flag to flask test.

@gwhitney gwhitney mentioned this pull request Apr 12, 2024
Closed
@gwhitney gwhitney marked this pull request as draft April 12, 2024 20:44
@gwhitney
Copy link
Collaborator Author

needs rebasing, will do so and then mark it as ready to merge again.

@gwhitney
feat: flask test -v sets maxDiff to None
229a6d3 
  This causes the output for any test failures to show full diffs, however
  large they may be.
  Resolves numberscope#116.
@gwhitney gwhitney marked this pull request as ready for review April 13, 2024 01:08
@gwhitney
Copy link
Collaborator Author

OK, @katestange @Vectornaut if one of you could review this and merge if all seems well; it's next up on the propose roadmap to the 22nd :)

katestange
katestange approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@katestange katestange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine tested on my system as you described.

@katestange katestange merged commit 8d5e8a4 into numberscope:main Apr 13, 2024
@Vectornaut
Copy link
Collaborator

I looked at wsgi.py, and tested the change as follows:

  1. Run tests and confirm that all pass.
  2. Change one digit of expected_oeis_response_b64, used in TestNonexistentSequence.
  3. Run tests without the verbose flag.
    ✅️ TestNonexistentSequence fails and shows a diff excerpt.
  4. Run tests with the verbose flag.
    ✅️ TestNonexistentSequence fails and shows a full diff.

@Vectornaut
Copy link
Collaborator

Haha, jinx! Thanks for the double-check, @katestange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katestange katestange katestange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flask test -v should show diffs
3 participants
@gwhitney @Vectornaut @katestange