Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flask test -v should show diffs #116

Closed
gwhitney opened this issue Apr 11, 2024 · 2 comments · Fixed by #117
Closed

flask test -v should show diffs #116

gwhitney opened this issue Apr 11, 2024 · 2 comments · Fixed by #117
Labels
blocked/blocking Is blocked or blocks development of something else maintenance Functionality-orthogonal refactoring or code cleanup that needs doing question Further information is requested

Comments

@gwhitney
Copy link
Collaborator

I am running into a test failure in the current state of #111. At the end of the failure report, it says

Diff is 6546 characters long. Set self.maxDiff to None to see it.

I re-ran with flask test -v. It seems to me that in verbose mode, it should always show the diffs.
I will work on a PR to that effect, in case @katestange @Vectornaut agree.
(In any case, a way to see the diffs would be handy in investigating what is going on in #111; so if this suggestion doesn't seem good, please recommend another convenient way to see the diffs.)
@gwhitney gwhitney added question Further information is requested maintenance Functionality-orthogonal refactoring or code cleanup that needs doing blocked/blocking Is blocked or blocks development of something else labels Apr 11, 2024
@katestange
Copy link
Member

That seems to make sense to me.

gwhitney added a commit to gwhitney/backscope that referenced this issue Apr 11, 2024
@gwhitney
feat: flask test -v sets maxDiff to None
08eee31 
  This causes the output for any test failures to show full diffs, however
  large they may be.
  Resolves numberscope#116.
@gwhitney gwhitney mentioned this issue Apr 11, 2024
Merged
@gwhitney
Copy link
Collaborator Author

gwhitney commented Apr 12, 2024 •
edited
Loading

OK, up to @Vectornaut whether to merge #117 first or #111 first, since he's the one that would be affected by it.

gwhitney added a commit to gwhitney/backscope that referenced this issue Apr 13, 2024
@gwhitney
feat: flask test -v sets maxDiff to None
229a6d3 
  This causes the output for any test failures to show full diffs, however
  large they may be.
  Resolves numberscope#116.
katestange pushed a commit that referenced this issue Apr 13, 2024
@gwhitney
feat: flask test -v sets maxDiff to None (#117)
8d5e8a4 
This causes the output for any test failures to show full diffs, however
  large they may be.
  Resolves #116.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked/blocking Is blocked or blocks development of something else maintenance Functionality-orthogonal refactoring or code cleanup that needs doing question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: flask test -v sets maxDiff to None gwhitney/backscope
2 participants
@gwhitney @katestange