Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates transform character scramble to return empty strings and nils properly #2692

Merged
merged 2 commits into from
Sep 13, 2024

updates to handle nil

d4845c5
Select commit
Loading
Failed to load commit list.
Merged

updates transform character scramble to return empty strings and nils properly #2692

updates to handle nil
d4845c5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 13, 2024 in 1s

36.44% (-0.05%) compared to 309afb7

View this Pull Request on Codecov

36.44% (-0.05%) compared to 309afb7

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 36.44%. Comparing base (309afb7) to head (d4845c5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nthos/transformers/transform_character_scramble.go 50.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
- Coverage   36.49%   36.44%   -0.05%     
==========================================
  Files         274      274              
  Lines       25615    25627      +12     
==========================================
- Hits         9347     9341       -6     
- Misses      15000    15016      +16     
- Partials     1268     1270       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov