Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates transform character scramble to return empty strings and nils properly #2692

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

nickzelei
Copy link
Member

No description provided.

@nickzelei nickzelei added the bug Something isn't working label Sep 13, 2024
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 9:48pm

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 36.44%. Comparing base (309afb7) to head (d4845c5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...nthos/transformers/transform_character_scramble.go 50.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
- Coverage   36.49%   36.44%   -0.05%     
==========================================
  Files         274      274              
  Lines       25615    25627      +12     
==========================================
- Hits         9347     9341       -6     
- Misses      15000    15016      +16     
- Partials     1268     1270       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei changed the title updates transform character scramble to return empty strings updates transform character scramble to return empty strings and nils properly Sep 13, 2024
@nickzelei nickzelei merged commit 21b8777 into main Sep 13, 2024
9 of 10 checks passed
@nickzelei nickzelei deleted the nick/fix-charscramble-str branch September 13, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants