Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @nteract/tranforms #655

Merged
merged 4 commits into from
Apr 11, 2017
Merged

Use @nteract/tranforms #655

merged 4 commits into from
Apr 11, 2017

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Mar 21, 2017

A initial stab at using @nteract/tranforms as a replacement for transformime in order to address #557, #560, #27 and #368 and support even more mimetypes.

Moved to a later time:

  • Use @nteract/tranforms for inspector (the easy part 😄 )
  • Refactor the following parts as React Components:
    • Result View probably powered by @nteract/display-area
      • Spinner component
      • Component for inline result
      • Component for multiline result
      • Component for rich output (I think we could even remove it and use the multiline output for simplicity and to have a more consistent appearance)
    • Watch Sidebar
      • Watch View component

There's quite a bit of work left to do and I don't know when I can get to it, so I'm parking it here 🚗
It would be super cool if someone wants to help with this effort 😇

as a drop-in-replacement of transformime
@lgeiger
Copy link
Member Author

lgeiger commented Apr 10, 2017

I aimed a bit high in this PR 😄

In my last commit I took a different approach to the problem and used @nteract/transforms as a drop-in replacement of transformime without any refactoring.
This way we can iterate on this and can use all the awesome transforms right now:

transforms

Now we can easily add support for more mime types or even use @nteract/transforms-full if apm handles the install nicely (one transform has node-canvas as a native but optional dependency which may cause install problems).

I propose we go with this as is and move the refactorings into the future.

It would be cool if someone could take this branch for a spin since there may some minor style glitches I didn't caught.

@lgeiger lgeiger changed the title [WIP] Use @nteract/tranforms Use @nteract/tranforms Apr 10, 2017
This can probably simplified even more
const result = {
data: data,
stream: "pyout"
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classic message spec before v5. 😉

Copy link
Member

@BenRussert BenRussert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge!

This adds a great feature while reducing total lines of code! So much cleaner now.

@rgbkrk rgbkrk merged commit 43b6677 into nteract:master Apr 11, 2017
@lgeiger lgeiger deleted the react-transforms branch April 11, 2017 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants