-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use @nteract/tranforms #655
Conversation
89ca225
to
5d4697f
Compare
5d4697f
to
d04700c
Compare
d04700c
to
a741824
Compare
a741824
to
adbc633
Compare
as a drop-in-replacement of transformime
adbc633
to
37f0349
Compare
I aimed a bit high in this PR 😄 In my last commit I took a different approach to the problem and used Now we can easily add support for more mime types or even use I propose we go with this as is and move the refactorings into the future. It would be cool if someone could take this branch for a spin since there may some minor style glitches I didn't caught. |
This can probably simplified even more
const result = { | ||
data: data, | ||
stream: "pyout" | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Classic message spec before v5. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to merge!
This adds a great feature while reducing total lines of code! So much cleaner now.
A initial stab at using
@nteract/tranforms
as a replacement fortransformime
in order to address #557, #560, #27 and #368 and support even more mimetypes.Moved to a later time:
@nteract/tranforms
for inspector (the easy part 😄 )@nteract/display-area
There's quite a bit of work left to do and I don't know when I can get to it, so I'm parking it here 🚗
It would be super cool if someone wants to help with this effort 😇