Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ggplot graphics truncated #676

Closed
piccolbo opened this issue Mar 29, 2017 · 5 comments · Fixed by #716
Closed

Ggplot graphics truncated #676

piccolbo opened this issue Mar 29, 2017 · 5 comments · Fixed by #716
Labels
bug 🐛 For unexpected issues

Comments

@piccolbo
Copy link

Description:

Ggplot for python graphics excludes x axis

Steps to Reproduce:

  1. [First Step]

Load ggplot
2. [Second Ste

Plot a graph

Sorry on a phone now can provide 4 line example

Versions:

Which OS and which version of Hydrogen and Atom are you running?
Os x Sierra hydrogen 1.8,0

You can get this information from copy and pasting the output of atom --version from the command line.

Logs:

Please post any error logs and the output of the developer tools as described in our Debugging Guide.

@BenRussert
Copy link
Member

@piccolbo can you be more specific? I ran some ggplot code just now and saw no issues.

@piccolbo
Copy link
Author

You bet!

import pandas as pd
import ggplot as gg
df = pd.DataFrame(dict(x = range (1,10), y = range(1,10)))
gg.ggplot(df, gg.aes(x='x', y = 'y')) + gg.geom_line()

screen shot 2017-03-29 at 9 59 43 pm

After my first report I discovered that if I select the gplot line and the following line, with a random harmless expression, and then evaluate, then the problem is lessened. But the graphics panel is still too small -- it scrolls though.

print(gg.ggplot(df, gg.aes(x='x', y = 'y')) + gg.geom_line())
1

screen shot 2017-03-29 at 10 05 32 pm

@BenRussert
Copy link
Member

Looks like this is the same isssue as #632. We are talking about an enhancement to resize images there.

I'll close this issue, but feel free to reply here or in #632 with any questions.

@piccolbo
Copy link
Author

I agree there's a big overlap with#632. But mostly for my education, when is the decision between inline and block graphics made? How can such a big inline bubble that covers the rest of the code make sense? Why no scroll bars if part of the graphics is hidden? My answer, coming from rstudio, would be never inline and always size the bubble big enough to avoid scrolling

@lgeiger
Copy link
Member

lgeiger commented Mar 30, 2017

That's definitely a bug.
It looks like we try to display the plot as a inline result bubble (no scrollbars...) since ggplot sends a small plot id (<ggplot: (12345)>) after the plot.

The relevant lines are here.
If there isn't a easy fix, I would suggest we fix it during #655.

@lgeiger lgeiger reopened this Mar 30, 2017
@lgeiger lgeiger added the bug 🐛 For unexpected issues label Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 For unexpected issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants