-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): update app and lib generators to support new TS solution setup #28808
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4c7d5e6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
a454c45
to
a2e9734
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28808-0f14212 my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-28808-0f14212
To request a new release for this pull request, mention someone from the Nx team or the |
0f14212
to
e812720
Compare
4f67272
to
18a3a8b
Compare
18a3a8b
to
ca32248
Compare
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
92a2604
to
4c7d5e6
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR updates app and lib generators in the following packages such that they will generate files with the TS solution setup if it is detected.
@nx/react
@nx/next
@nx/remix
@nx/expo
@nx/react-native
React apps and libs will be linked using npm/pnpm/yarn/bun workspaces feature rather than through tsconfig paths. This means that local aliases like
@/
will work with Next.js and Remix apps.Note: This will be behind
--workspaces
flag when usingnpx create-nx-workspace
and choosing React stack. If you use the None/TS stack then adding plugins likenx add @nx/react
then generating apps, it will automatically pick up the new TS solution setup.Current Behavior
React generators are not compatible with TS solution setup (i.e. workspaces + TS project references).
Expected Behavior
React generators work with new TS solution setup (Plain, Next.js, Remix, Expo, React Native).
Related Issue(s)
#28322