Skip to content

Commit

Permalink
fix(core): add expo/rn to also setup workspaces
Browse files Browse the repository at this point in the history
  • Loading branch information
jaysoo committed Nov 12, 2024
1 parent 8f5ce44 commit 0f14212
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions packages/expo/src/generators/application/application.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export async function expoApplicationGeneratorInternal(
jsx: 'react-jsx',
module: 'esnext',
moduleResolution: 'bundler',
noUnusedLocals: false,
});

if (!options.skipFormat) {
Expand Down
2 changes: 1 addition & 1 deletion packages/js/src/utils/typescript/ts-solution-setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export function updateTsconfigFiles(
tree: Tree,
projectRoot: string,
runtimeTsconfigFileName: string,
compilerOptions: Record<string, string>
compilerOptions: Record<string, string | boolean>
) {
if (!isUsingTsSolutionSetup(tree)) return;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ export async function reactNativeApplicationGeneratorInternal(
jsx: 'react-jsx',
module: 'esnext',
moduleResolution: 'bundler',
noUnusedLocals: false,
});

if (!options.skipFormat) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -415,8 +415,10 @@ function setUpWorkspacesInPackageJson(tree: Tree, options: NormalizedSchema) {
if (
options.preset === Preset.NPM ||
((options.preset === Preset.TS ||
options.preset === Preset.ReactMonorepo ||
options.preset === Preset.Expo ||
options.preset === Preset.NextJs ||
options.preset === Preset.ReactMonorepo ||
options.preset === Preset.ReactNative ||
options.preset === Preset.RemixMonorepo) &&
process.env.NX_ADD_PLUGINS !== 'false' &&
process.env.NX_ADD_TS_PLUGIN !== 'false')
Expand Down

0 comments on commit 0f14212

Please sign in to comment.