Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve about dialog texts #176

Merged
merged 1 commit into from
May 9, 2019
Merged

Conversation

bagage
Copy link
Collaborator

@bagage bagage commented May 9, 2019

Before:

image

After:

image

⚠️ when merged we must push to transifex new source file.

@nrenner nrenner merged commit 0aa1a81 into nrenner:master May 9, 2019
@nrenner
Copy link
Owner

nrenner commented May 9, 2019

That was on a bit on purpose to make the difference explicit, but yes, it's more concise now.

@nrenner
Copy link
Owner

nrenner commented May 9, 2019

warning when merged we must push to transifex new source file.

Is that something different than yarn transifex-push? Doing a yarn transifex-pull after push, now your translations are reverted to english?

Layer translations are deleted in locales/en.json and translations (didn't notice that before). Forgot to include layers/config/overrides.js in the i18next task. Will look at this tomorrow.

@nrenner
Copy link
Owner

nrenner commented May 10, 2019

Ok, my translations mess should be fixed now, this is what I have done:

  • restored layer keys (d8886e7) and texts (66cdc84)
  • tx push --source to add the restored layer keys
  • tx push -t -f to force push the translations of this PR and to restore the deleted layer translations
  • restore changes overwritten by force (manually on Transifex) since last update, only one found:
    • fr: Ascend (Plain ascend) = Dénivelé cumulé (dénivelé global)
  • yarn transifex-pull

@nrenner
Copy link
Owner

nrenner commented May 10, 2019

Just got a message from Transifex that all languages are now 100% translated. Turns out force pushing language files wasn't such a good idea, as all previously untranslated texts are now set to their en fallback text.

Any idea how to reset the en texts, except doing it manually?

At least there is a time-based filter, e.g. translated_after:2019-05-05.

@bagage
Copy link
Collaborator Author

bagage commented May 10, 2019

Hm you are right. Sorry about that mess.

Just to be clear, but I believe you understood it by now: yarn transifex-push will only push English version to transifex, not other languages. Since it was only some typography stuff I wanted to do it directly but I should have done it on Transifex instead.

Anyway, I'll take a look at that and let you know if I can find something.

@bagage
Copy link
Collaborator Author

bagage commented May 10, 2019

I don't see any option on transifex site directly. However something that may work would be to force push json files after having removed translations that are identical to English, for all files. Only non translatable / identic words would be lost, but there are not many I believe.

I can do it if you wish @nrenner.

@nrenner
Copy link
Owner

nrenner commented May 10, 2019

Thanks for helping to look for a solution.

I thought about it and I think deleting the english texts manually on Transifex using above filter is probably the best and safest option. It's only about hu, pt and zh_TW anyway.

I can do it probably tomorrow afternoon, but you can also do it if you feel like it, I don't mind either way.

@bagage
Copy link
Collaborator Author

bagage commented May 10, 2019

Should be fixed :).

@nrenner
Copy link
Owner

nrenner commented May 10, 2019

Great, thanks!

@nrenner nrenner added this to the 0.9.0 milestone May 17, 2019
@bagage bagage deleted the fix-about-text branch May 27, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants