Follow up to #753. Explicitly cast config to regconfig. #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwasef1830
requested review from
austindrenski,
roji and
YohDeadfall
as code owners
austindrenski
approved these changes
Mar 1, 2019
|
@rwasef1830 Can you rebase to pick up 0d99ac5? |
rwasef1830
force-pushed
the
regconfig-explicit-cast-followup
branch
from
ecdc6a9 to
eb20a9e
Compare
|
@austindrenski done. |
|
So, should I just rebase and merge this ? @roji @austindrenski @YohDeadfall |
YohDeadfall
approved these changes
Mar 12, 2019
roji
approved these changes
Mar 14, 2019
There was a problem hiding this comment.
Sorry for taking so long with this.
@smitpatel (and others), this is a somewhat interesting case where the type inference planned for 3.0 could be helpful. Rather than an explicit SQL cast, the full text functions would be known to accept the regconfig type, and the correct type mapping will be automatically selected.
rwasef1830
force-pushed
the
regconfig-explicit-cast-followup
branch
from
eb20a9e to
7bdc0c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #753
CC @austindrenski @CornedBee