Implement DbFunctions extensions for websearch_to_tsquery (#629)

[CornedBee]

This resolves half of issue #629

[CornedBee]

So apparently the appveyor test environment still uses PostgreSQL 10. That can't work for this PR.

[austindrenski]

Thanks for putting this together. Just a couple of comments included in this review.

We'll need to wait to merge until the CI environment is upgraded. That might not be soon, but it should certainly happen before the 3.0 release in 2019Q1.

[austindrenski]

Thanks for making these changes. One small nit to address, and then I think this will be good to go.

[CornedBee]

Thanks for the thorough review.

[austindrenski]

Opened appveyor/ci#2805 to request an ETA on PG 11 from AppVeyor.

[austindrenski]

Per appveyor/ci#2805, PostgreSQL 11 should be available after the next image update.

[austindrenski]

This is no longer blocked by AppVeyor, just by our CI configuration.

https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/blob/e3421fa3e4d45546192069716bb94b77bf015a60/.appveyor.yml#L3-L16

[roji]

#822 was merged, updating our CI environment. Do you mind rebasing on the latest dev and pushing again?

[CornedBee]

I updated, do you get notifications for that?

[austindrenski]

@CornedBee We don't necessarily get notifications for new commits, so thanks for the ping. I just merged, so this should be available in the next preview release.

Thank you for your contribution!

[rwasef1830]

@austindrenski @CornedBee the commit is missing updating TryTranslateDbFunctionExtension in Query/ExpressionTranslators/Internal/NpgsqlFullTextSearchMethodTranslator.cs to handle regconfig parameter being a variable. This will cause an exception when regconfig parameter is passed as a variable.

A case for the new method needs to be added so that regconfig explicit cast is emitted.

[austindrenski]

Yikes, thanks for catching that @rwasef1830... Does one of you have time to submit a patch (and relevant unit tests)?