-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ber to der convertor #11
Conversation
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Partial review
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Partial review; ber.go
has not been reviewed yet.
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as all my review comments were resolved in PR 176: notaryproject/notation-core-go#176
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as all my review comments were resolved in PR 176: notaryproject/notation-core-go#176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
commit 2862807 Author: Junjie Gao <junjiegao@microsoft.com> Date: Wed Jan 31 15:21:55 2024 +0800 feat: ber to der convertor (notaryproject#11) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> commit a373599 Author: Patrick Zheng <patrickzheng@microsoft.com> Date: Mon Jan 22 16:37:33 2024 +0800 ci: add MAKEFILE and build workflow to the repo (notaryproject#19) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> commit 6fa8c7f Author: Patrick Zheng <patrickzheng@microsoft.com> Date: Mon Jan 22 16:36:50 2024 +0800 ci: add dependabot (notaryproject#16) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> commit bdae447 Author: Patrick Zheng <patrickzheng@microsoft.com> Date: Mon Jan 22 16:36:24 2024 +0800 ci: add code coverage check (notaryproject#15) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> commit 4cc6846 Author: Patrick Zheng <patrickzheng@microsoft.com> Date: Mon Jan 22 16:35:54 2024 +0800 ci: add license checker to the repo (notaryproject#13) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> commit a27c098 Author: Yi Zha <yizha1@microsoft.com> Date: Thu Jan 18 10:02:22 2024 +0800 chore: add CODEOWNERS and MAINTAINERS file (notaryproject#12) Resolve notaryproject#2 Signed-off-by: Yi Zha <yizha1@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao junjiegao@microsoft.com