Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tspclient package #18

Merged
merged 53 commits into from
Jun 27, 2024
Merged

feat: add tspclient package #18

merged 53 commits into from
Jun 27, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Jan 19, 2024 •
edited
Loading

This PR adds the tspclient package to the repo. It's an implementation of RFC 3161.

Related unit tests and conformance tests are included in this PR as well.

@Two-Hearts
added timestamp package
88866f4 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts requested review from JeyJeyGao, shizhMSFT and a team as code owners January 19, 2024 05:14
@Two-Hearts
updated dependency
33f5952 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
JeyJeyGao reviewed Jan 19, 2024
View reviewed changes
timestamp/request.go Outdated Show resolved Hide resolved
timestamp/request.go Outdated Show resolved Hide resolved
timestamp/request.go Outdated Show resolved Hide resolved
timestamp/request.go Outdated Show resolved Hide resolved
timestamp/response.go Outdated Show resolved Hide resolved
timestamp/http.go Outdated Show resolved Hide resolved
timestamp/token.go Outdated Show resolved Hide resolved
timestamp/token.go Outdated Show resolved Hide resolved
@Two-Hearts
updated to tspclient
86b9b3b 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts changed the title feat: add timestamp feat: add tspclient package Jan 22, 2024
@Two-Hearts
clean up
8598d91 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
Merge branch 'notaryproject:main' into timestamp
5453b96
@Two-Hearts
update
11e03e9 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
debug
0532d52 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update
018c547 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
fix license
2bc44d9 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
JeyJeyGao reviewed Jan 23, 2024
View reviewed changes
token.go Outdated Show resolved Hide resolved
@Two-Hearts
update
5f0e2cc 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update
50ddae5 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
updated pki
55fba00 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts requested a review from JeyJeyGao January 29, 2024 06:20
@Two-Hearts
update
3fbb0c0 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
JeyJeyGao reviewed Jan 29, 2024
View reviewed changes
http.go Outdated Show resolved Hide resolved
response.go Show resolved Hide resolved
response.go Show resolved Hide resolved
@Two-Hearts Two-Hearts closed this Jan 31, 2024
@Two-Hearts
resolved conflicts
ba59581 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts reopened this Jan 31, 2024
@Two-Hearts
Merge branch 'notaryproject:main' into timestamp
820929d
@Two-Hearts
updated per code review
45076e8 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts requested a review from JeyJeyGao February 1, 2024 08:06
@Two-Hearts Two-Hearts mentioned this pull request Mar 21, 2024
Merged
@Two-Hearts
update
7c5c914 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
shizhMSFT reviewed Jun 14, 2024
View reviewed changes
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR except response.go and token.go.

internal/oid/hash.go Outdated Show resolved Hide resolved
internal/oid/oid.go Outdated Show resolved Hide resolved
pki/pki.go Outdated Show resolved Hide resolved
pki/pki.go Outdated Show resolved Hide resolved
pki/pki.go Outdated Show resolved Hide resolved
http.go Outdated Show resolved Hide resolved
http.go Outdated Show resolved Hide resolved
request.go Show resolved Hide resolved
request.go Show resolved Hide resolved
request.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Jun 14, 2024
View reviewed changes
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the rest of the files.

response.go Outdated Show resolved Hide resolved
response.go Outdated Show resolved Hide resolved
response.go Show resolved Hide resolved
response.go Outdated Show resolved Hide resolved
token.go Outdated Show resolved Hide resolved
token.go Outdated Show resolved Hide resolved
token.go Show resolved Hide resolved
token.go Outdated Show resolved Hide resolved
@Two-Hearts
updated per code review
bd7e551 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts requested a review from shizhMSFT June 17, 2024 05:35
@Two-Hearts
updated per code review
e224399 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
shizhMSFT reviewed Jun 17, 2024
View reviewed changes
pki/pki.go Outdated Show resolved Hide resolved
pki/pki.go Outdated Show resolved Hide resolved
request.go Outdated Show resolved Hide resolved
response.go Outdated Show resolved Hide resolved
@Two-Hearts
updated per code review
6953545 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
updated per code review
cd78afa 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
updated per code review
8938258 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts requested a review from shizhMSFT June 18, 2024 02:23
shizhMSFT
shizhMSFT previously approved these changes Jun 18, 2024
View reviewed changes
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts mentioned this pull request Jun 20, 2024
Merged
@Two-Hearts
root cert pool
c9a7560 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
root cert pool
2126d69 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update tsa root cert pool
df61b1a 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
fix
09fe8fb 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
fix
22fd76e 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
updated root cert pool
1284fbf 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
clean up
b86a837 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts requested a review from shizhMSFT June 25, 2024 05:12
shizhMSFT
shizhMSFT approved these changes Jun 26, 2024
View reviewed changes
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jun 27, 2024
Merged
Merged
JeyJeyGao
JeyJeyGao approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Jun 27, 2024
View reviewed changes
Copy link

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit dcff9b7 into notaryproject:main Jun 27, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the timestamp branch June 27, 2024 05:04
@Two-Hearts Two-Hearts mentioned this pull request Jul 9, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Two-Hearts @codecov-commenter @priteshbandi @shizhMSFT @JeyJeyGao