Status bar error color tokens #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS Code 1.52 [1] (November 2020) introduced new theme color tokens for error items in the status bar [2]. The following token have been added to make it more conform with Nord's style: - `statusBarItem.errorBackground` - status bar error items background color. Error items stand out from other status bar entries to indicate error conditions. - `statusBarItem.errorForeground` - status bar error items foreground color. Error items stand out from other status bar entries to indicate error conditions. [1]: https://code.visualstudio.com/updates/v1_52 [2]: https://code.visualstudio.com/updates/v1_52#_new-theme-colors Co-authored-by: Sven Greb <development@svengreb.de> GH-203
svengreb
approved these changes
Jun 22, 2021
arcticicestudio
added a commit
that referenced
this pull request
Jun 22, 2021
VS Code 1.52 [1] (November 2020) introduced new theme color tokens for error items in the status bar [2]. The following token have been added to make it more conform with Nord's style: - `statusBarItem.errorBackground` - status bar error items background color. Error items stand out from other status bar entries to indicate error conditions. - `statusBarItem.errorForeground` - status bar error items foreground color. Error items stand out from other status bar entries to indicate error conditions. [1]: https://code.visualstudio.com/updates/v1_52 [2]: https://code.visualstudio.com/updates/v1_52#_new-theme-colors Co-authored-by: Sven Greb <development@svengreb.de> Closes GH-203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #203