Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar error color tokens #203

Closed
arcticicestudio opened this issue Jun 20, 2021 · 0 comments · Fixed by #212
Closed

Status bar error color tokens #203

arcticicestudio opened this issue Jun 20, 2021 · 0 comments · Fixed by #212

Comments

@arcticicestudio
Copy link
Contributor

VS Code 1.52 (November 2020) introduced new theme color tokens for error items in the status bar.

The following token will be added to make it more conform with Nord's style:

  • statusBarItem.errorBackground — status bar error items background color. Error items stand out from other status bar entries to indicate error conditions.
  • statusBarItem.errorForeground — status bar error items foreground color. Error items stand out from other status bar entries to indicate error conditions.
@arcticicestudio arcticicestudio added this to the Next milestone Jun 20, 2021
arcticicestudio added a commit that referenced this issue Jun 22, 2021
VS Code 1.52 [1] (November 2020) introduced new theme color tokens for
error items in the status bar [2].

The following token have been added to make it more conform with Nord's
style:

- `statusBarItem.errorBackground` - status bar error items background
  color. Error items stand out from other status bar entries to indicate
  error conditions.
- `statusBarItem.errorForeground` - status bar error items foreground
  color. Error items stand out from other status bar entries to indicate
  error conditions.

[1]: https://code.visualstudio.com/updates/v1_52
[2]: https://code.visualstudio.com/updates/v1_52#_new-theme-colors

Co-authored-by: Sven Greb <development@svengreb.de>

GH-203
arcticicestudio added a commit that referenced this issue Jun 22, 2021
VS Code 1.52 [1] (November 2020) introduced new theme color tokens for
error items in the status bar [2].

The following token have been added to make it more conform with Nord's
style:

- `statusBarItem.errorBackground` - status bar error items background
  color. Error items stand out from other status bar entries to indicate
  error conditions.
- `statusBarItem.errorForeground` - status bar error items foreground
  color. Error items stand out from other status bar entries to indicate
  error conditions.

[1]: https://code.visualstudio.com/updates/v1_52
[2]: https://code.visualstudio.com/updates/v1_52#_new-theme-colors

Co-authored-by: Sven Greb <development@svengreb.de>

Closes GH-203
arcticicestudio added a commit that referenced this issue Jun 22, 2021
VS Code 1.52 [1] (November 2020) introduced new theme color tokens for
error items in the status bar [2].

The following token have been added to make it more conform with Nord's
style:

- `statusBarItem.errorBackground` - status bar error items background
  color. Error items stand out from other status bar entries to indicate
  error conditions.
- `statusBarItem.errorForeground` - status bar error items foreground
  color. Error items stand out from other status bar entries to indicate
  error conditions.

[1]: https://code.visualstudio.com/updates/v1_52
[2]: https://code.visualstudio.com/updates/v1_52#_new-theme-colors

Co-authored-by: Sven Greb <development@svengreb.de>

Closes GH-203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants