Text color related workbench theme keys #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
svengreb
previously approved these changes
Oct 8, 2019
This commit adds some workbench color keys for text related elements that were not supported by Nord yet. The commit in the VS Code repository (1) added multiple new theme key in through microsoft/vscode#26298 that was merged over 2 years ago and released for the first time in stable version 1.13.0 (2) but were never mentioned in the release notes. The following theme keys have now been added: - `textBlockQuote.background` - Background color for block quotes in text. - `textBlockQuote.border` - Right-side border color for block quotes in text. - `textLink.activeForeground` - Foreground color for links in text when clicked on and on mouse hover. - `textLink.foreground` - Foreground color for links in text. - `textPreformat.foreground` - Foreground color for preformatted text segments like inline code. - `textSeparator.foreground` - Color for text separators. References: (1) https://github.com/microsoft/vscode/blame/752acd504206f00ffe4ed101c2496540d0197f56/src/vs/platform/theme/common/colorRegistry.ts#L164-L170 (2) https://code.visualstudio.com/updates/v1_13 GH-154
arcticicestudio
force-pushed
the
feature/gh-154-text-colors
branch
from
f884e94 to
6b5bac3
Compare
svengreb
approved these changes
Oct 8, 2019
arcticicestudio
added a commit
that referenced
this pull request
Dec 23, 2019
This PR adds some workbench color keys for text related elements that were not supported by Nord yet. The commit in the VS Code repository (1) (Micorosft/vscode@752acd50) added multiple new theme key in through microsoft/vscode#26298 (2) that was merged over 2 years ago and released for the first time in stable version 1.13.0 (3) but were never mentioned in the release notes. The following theme keys have now been added: - `textBlockQuote.background` - Background color for block quotes in text. - `textBlockQuote.border` - Right-side border color for block quotes in text. - `textLink.activeForeground` - Foreground color for links in text when clicked on and on mouse hover. - `textLink.foreground` - Foreground color for links in text. - `textPreformat.foreground` - Foreground color for preformatted text segments like inline code. - `textSeparator.foreground` - Color for text separators. References: (1) https://github.com/microsoft/vscode/blame/752acd504206f00ffe4ed101c2496540d0197f56/src/vs/platform/theme/common/colorRegistry.ts#L164-L170 (2) microsoft/vscode#26298 (3) https://code.visualstudio.com/updates/v1_13 Resolves GH-154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154
This PR adds some workbench color keys for text related elements that were not supported by Nord yet.
The commit in the VS Code repository (Micorosft/vscode@752acd50) added multiple new theme key in through microsoft/vscode#26298 that was merged over 2 years ago and released for the first time in stable version 1.13.0 but were never mentioned in the release notes.
The following theme keys have now been added:
textBlockQuote.background- Background color for block quotes in text.textBlockQuote.border- Right-side border color for block quotes in text.textLink.activeForeground- Foreground color for links in text when clicked on and on mouse hover.textLink.foreground- Foreground color for links in text.textPreformat.foreground- Foreground color for preformatted text segments like inline code.textSeparator.foreground- Color for text separators.Interactive Playground before/after
Interface Overview before/after
Welcome Screen before/after