Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing textLink colors #154

Closed
imtbl opened this issue Aug 18, 2019 · 2 comments · Fixed by #159
Closed

Missing textLink colors #154

imtbl opened this issue Aug 18, 2019 · 2 comments · Fixed by #159

Comments

@imtbl
Copy link

imtbl commented Aug 18, 2019

I felt like the issue template was a bit overkill for this; please let me know if this format is not acceptable.


Issue

The theme seems to be missing the custom colors for textLinkForeground and textLinkActiveForeground, causing certain links to use the default color #3794ff and look like this:

image

Workaround

The default color for textLinkForeground and textLinkActiveForeground is #3794ff when using a dark theme.

This is the same as for pickerGroupForeground, for which you already use #88c0d0.

According to this, setting the following manually in VS Code's settings.json brings the desired result:

{
  "workbench.colorCustomizations": {
    "[Nord]": {
      "textLink.foreground": "#88c0d0",
      "textLink.activeForeground": "#88c0d0"
    }
  }
}
@arcticicestudio arcticicestudio self-assigned this Aug 18, 2019
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Aug 18, 2019

Hi @mserajnik 👋, thanks for your contribution 👍

It looks like there are even more colors for text related elements that are not supported by Nord yet 😯
I've checked for the missing textLink.activeForeground theme key you've found and tracked down the commit where it was added to VS Code. They've added multiple new theme key in through microsoft/vscode#26298 that was merged over 2 years ago and released for the first time in stable version 1.13.0 but were never mentioned in the release notes.

I'll add all the currently missing theme keys:

  • textSeparator.*
  • textBlockQuote.*
  • textPreformat.*
  • textLink.*
  • textCodeBlock.*

I've also created a small daemon (in Go 💙) running on my server that checks for new commits in open source projects for specific files and creates reports. I guess I'll add VS Code's colorRegistry.ts file and parse it to check for other missing keys that were not documented in any release notes.

Regarding the issue template: Your issue is totally fine and well understandable! The issue template is only so detailed and extensive to prevent one-liner or "title-only" reports as well as collecting as many details as possible to better reproduce problems. When you've got 400+ issues/PRs in your queue you're thankful for any bit of additional information to process these piles of tickets 😉

@arcticicestudio arcticicestudio added this to the Next milestone Aug 18, 2019
arcticicestudio added a commit that referenced this issue Oct 3, 2019
This commit adds some workbench color keys for text related elements
that were not supported by Nord yet.
The commit in the VS Code repository (1) added multiple new theme key
in through microsoft/vscode#26298 that was
merged over 2 years ago and released for the first time in stable
version 1.13.0 (2) but were never mentioned in the release notes.

The following theme keys have now been added:

- `textBlockQuote.background` - Background color for block quotes in
  text.
- `textBlockQuote.border` - Right-side border color for block quotes in
  text.
- `textLink.activeForeground` - Foreground color for links in text when
  clicked on and on mouse hover.
- `textLink.foreground` - Foreground color for links in text.
- `textPreformat.foreground` - Foreground color for preformatted text
  segments like inline code.
- `textSeparator.foreground` - Color for text separators.

References:
  (1) https://github.com/microsoft/vscode/blame/752acd504206f00ffe4ed101c2496540d0197f56/src/vs/platform/theme/common/colorRegistry.ts#L164-L170
  (2) https://code.visualstudio.com/updates/v1_13

GH-154
@arcticicestudio
Copy link
Contributor

I've submitted PR #159 that adds the missing workbench theme keys listed above.

arcticicestudio added a commit that referenced this issue Oct 8, 2019
This commit adds some workbench color keys for text related elements
that were not supported by Nord yet.
The commit in the VS Code repository (1) added multiple new theme key
in through microsoft/vscode#26298 that was
merged over 2 years ago and released for the first time in stable
version 1.13.0 (2) but were never mentioned in the release notes.

The following theme keys have now been added:

- `textBlockQuote.background` - Background color for block quotes in
  text.
- `textBlockQuote.border` - Right-side border color for block quotes in
  text.
- `textLink.activeForeground` - Foreground color for links in text when
  clicked on and on mouse hover.
- `textLink.foreground` - Foreground color for links in text.
- `textPreformat.foreground` - Foreground color for preformatted text
  segments like inline code.
- `textSeparator.foreground` - Color for text separators.

References:
  (1) https://github.com/microsoft/vscode/blame/752acd504206f00ffe4ed101c2496540d0197f56/src/vs/platform/theme/common/colorRegistry.ts#L164-L170
  (2) https://code.visualstudio.com/updates/v1_13

GH-154
arcticicestudio added a commit that referenced this issue Oct 8, 2019
This PR adds some workbench color keys for text related elements
that were not supported by Nord yet.
The commit in the VS Code repository (1)
(Micorosft/vscode@752acd50) added multiple new theme key
in through microsoft/vscode#26298 (2) that was
merged over 2 years ago and released for the first time in stable
version 1.13.0 (3) but were never mentioned in the release notes.

The following theme keys have now been added:

- `textBlockQuote.background` - Background color for block quotes in
  text.
- `textBlockQuote.border` - Right-side border color for block quotes in
  text.
- `textLink.activeForeground` - Foreground color for links in text when
  clicked on and on mouse hover.
- `textLink.foreground` - Foreground color for links in text.
- `textPreformat.foreground` - Foreground color for preformatted text
  segments like inline code.
- `textSeparator.foreground` - Color for text separators.

References:
  (1) https://github.com/microsoft/vscode/blame/752acd504206f00ffe4ed101c2496540d0197f56/src/vs/platform/theme/common/colorRegistry.ts#L164-L170
  (2) microsoft/vscode#26298
  (3) https://code.visualstudio.com/updates/v1_13

Resolves GH-154
@arcticicestudio arcticicestudio removed their assignment Oct 8, 2019
arcticicestudio added a commit that referenced this issue Dec 23, 2019
This PR adds some workbench color keys for text related elements
that were not supported by Nord yet.
The commit in the VS Code repository (1)
(Micorosft/vscode@752acd50) added multiple new theme key
in through microsoft/vscode#26298 (2) that was
merged over 2 years ago and released for the first time in stable
version 1.13.0 (3) but were never mentioned in the release notes.

The following theme keys have now been added:

- `textBlockQuote.background` - Background color for block quotes in
  text.
- `textBlockQuote.border` - Right-side border color for block quotes in
  text.
- `textLink.activeForeground` - Foreground color for links in text when
  clicked on and on mouse hover.
- `textLink.foreground` - Foreground color for links in text.
- `textPreformat.foreground` - Foreground color for preformatted text
  segments like inline code.
- `textSeparator.foreground` - Color for text separators.

References:
  (1) https://github.com/microsoft/vscode/blame/752acd504206f00ffe4ed101c2496540d0197f56/src/vs/platform/theme/common/colorRegistry.ts#L164-L170
  (2) microsoft/vscode#26298
  (3) https://code.visualstudio.com/updates/v1_13

Resolves GH-154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants